Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple containers in componentSpecs.spec.containers not supported? #718

Closed
phsiao opened this issue Jul 22, 2019 · 3 comments
Closed

multiple containers in componentSpecs.spec.containers not supported? #718

phsiao opened this issue Jul 22, 2019 · 3 comments
Assignees
Labels
Projects

Comments

@phsiao
Copy link
Contributor

phsiao commented Jul 22, 2019

Don't know if this was the design goal, but I was assuming it would support multiple containers (not all being used for serving, for example, opentracing agent sidecar); however, it does not appear to work, and cursory inspection of the code I think the problem is https://github.com/SeldonIO/seldon-operator/blob/master/pkg/controller/seldondeployment/seldondeployment_controller.go#L635 where there is no matching graph entry and it does not know what to do with it.

@ukclivecox
Copy link
Contributor

Its definitely meant to be allowed to have multiple containers including ones outside the graph. This must be a bug introduced on the move to the Go operator.

@ukclivecox ukclivecox added the bug label Jul 23, 2019
@ukclivecox ukclivecox added this to To do in 0.4.0 via automation Jul 23, 2019
@ukclivecox ukclivecox self-assigned this Jul 23, 2019
@ukclivecox
Copy link
Contributor

can you retest with 0.3.2-SNAPSHOT release from master? This should be fixed.

@ukclivecox ukclivecox moved this from To do to In progress in 0.4.0 Aug 8, 2019
@phsiao
Copy link
Contributor Author

phsiao commented Aug 8, 2019

Confirmed that I can add additional container without problem in a very simple case. Thanks!

0.4.0 automation moved this from In progress to Done Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
0.4.0
  
Done
Development

No branches or pull requests

2 participants