Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set JSON_SORT_KEYS and JSONIFY_PRETTYPRINT_REGULAR to False by default #964

Closed
kparaju opened this issue Oct 17, 2019 · 1 comment · Fixed by #1030
Closed

Set JSON_SORT_KEYS and JSONIFY_PRETTYPRINT_REGULAR to False by default #964

kparaju opened this issue Oct 17, 2019 · 1 comment · Fixed by #1030
Assignees
Projects
Milestone

Comments

@kparaju
Copy link
Contributor

kparaju commented Oct 17, 2019

During our testing we have found out that setting JSON_SORT_KEYS and JSONIFY_PRETTYPRINT_REGULAR to False (in older version of flasks this is True by default) in flask increases performance quite a bit. especially if your payload is huge.

This is because formatting will create lots of whitespace characters that gets sent through the wire and it takes computational resource. JSON_SORT_KEYS=False will also cause us not to unnecessarily sort keys of the dictionary.

I can work on this in the next ~week or so.

@ukclivecox
Copy link
Contributor

Great. That sounds very useful additions to the python wrapper.

@ukclivecox ukclivecox added this to To do in 0.5.0 via automation Oct 17, 2019
@ukclivecox ukclivecox added this to the 0.5.x milestone Oct 17, 2019
@ukclivecox ukclivecox added this to To do in 1.0 via automation Oct 31, 2019
@ukclivecox ukclivecox removed this from To do in 0.5.0 Oct 31, 2019
@ukclivecox ukclivecox modified the milestones: 0.5.x, 1.0.x Oct 31, 2019
1.0 automation moved this from To do to Done Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants