Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to disable Redis in seldon-core helm chart #304

Closed
ChenyuanZ opened this issue Nov 19, 2018 · 1 comment
Closed

Allow user to disable Redis in seldon-core helm chart #304

ChenyuanZ opened this issue Nov 19, 2018 · 1 comment

Comments

@ChenyuanZ
Copy link
Contributor

Redis shipped in seldon-core helm chart is used for two purposes:

  1. Store oauth keys for seldon-apiserver.
  2. Persist Predictive Unit if its .s2i/environment PERSISTENCE flag is set to 1.

Since we can use ambassador to replace seldon-apiserver (which means we can disable seldon-apiserver in that case), and we can use a different Redis server for PERSISTENCE flag (if the admin already has a Redis server running), there is a need to disable the Redis shipped in seldon-core helm chart.
@ChenyuanZ ChenyuanZ mentioned this issue Nov 19, 2018
Merged
@ukclivecox
Copy link
Contributor

Fixed by #305

agrski added a commit that referenced this issue Dec 2, 2022
@agrski
Add build info to Hodometer Docker images (#304)
18cf74f 
* Bump Hodometer version

* Allow git & release-type Make vars to be overridden

* Add Docker build args for git info & release type

* Provide Docker build args via Make target

* Move Docker build args to just before use

This avoids invalidating subsequent layers, even when they haven't really changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChenyuanZ @ukclivecox