Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp how the engine handles metadata #426

Closed
jklaise opened this issue Jan 31, 2019 · 1 comment
Closed

Revamp how the engine handles metadata #426

jklaise opened this issue Jan 31, 2019 · 1 comment
Assignees
Projects

Comments

@jklaise
Copy link
Member

jklaise commented Jan 31, 2019

Currently the engine merges the metadata between components based on whatever metadata the new component adds:

private SeldonMessage mergeMeta(SeldonMessage message, List<SeldonMessage> messages) {
Meta.Builder metaBuilder = Meta.newBuilder(message.getMeta());
for (SeldonMessage originalMessage : messages){
metaBuilder.putAllTags(originalMessage.getMeta().getTagsMap());
}
metaBuilder.clearMetrics();
return SeldonMessage.newBuilder(message).setMeta(metaBuilder).build();
}
private SeldonMessage mergeMeta(SeldonMessage message, Meta meta) {
Meta.Builder metaBuilder = Meta.newBuilder(message.getMeta());
metaBuilder.putAllTags(meta.getTagsMap());
metaBuilder.clearMetrics();
return SeldonMessage.newBuilder(message).setMeta(metaBuilder).build();
}

A drawback of this is that some metadata can get lost, e.g. the engine currently doesn't pass the puid along (#424 fixes this). A better way would be only to add to the metadata so nothing is lost in the flow.

@jklaise jklaise added this to the 0.2.x milestone Jan 31, 2019
@jklaise jklaise added this to To do in 0.2.6 via automation Jan 31, 2019
@ukclivecox ukclivecox removed this from To do in 0.2.6 Feb 18, 2019
@ukclivecox ukclivecox modified the milestones: 0.2.x, 0.3.x Jun 3, 2019
@ukclivecox
Copy link
Contributor

Close. Can reopen if we decide to revamp how metadata is handled in general on a per-request basis.

agrski pushed a commit that referenced this issue Dec 2, 2022
onyx -> onnx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.3.0
  
Awaiting triage
Development

No branches or pull requests

2 participants