Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a NULL/None type in the CRD #554

Closed
jklaise opened this issue May 8, 2019 · 2 comments
Closed

Provide a NULL/None type in the CRD #554

jklaise opened this issue May 8, 2019 · 2 comments
Assignees

Comments

@jklaise
Copy link
Member

jklaise commented May 8, 2019

In Python it is a valid convention to use None as a default value for a parameter, however for Python components if we want to document in the deployment manifest all parameters with a default value of None, currently we would have to pass is as a STRING parameter and do post-processing in the Python wrapper (e.g. explicitly checking if the STRING is "None" and if so setting the parameter to None), this would introduces another convention to document.

@jklaise
Copy link
Member Author

jklaise commented May 9, 2019

Alternative solutions:

In any case there will also be a change in the corresponding wrapper code.

@ukclivecox
Copy link
Contributor

Given this seems to be more of a documenting process and I can't see a neat solution to fix this will close. Open if I am mistaken.

agrski added a commit that referenced this issue Dec 2, 2022
* Remove duplicated pipeline metrics

The inference request count and latency are tracked in the corresponding histogram,
under the '_count' and '_sum' metrics respectively.
Duplicating these adds almost 40% extra timeseries pressure per pipeline
and would likely confuse users who can't be sure which metric they should use.

* Add explanatory comment on aggregate metrics for pipelines

* Split gateway metrics constants into blocks & tidy surrounding comments

* Split agent metrics constants into blocks & tidy surrounding comments

* Remove duplicated agent metrics

The same reasoning applies as for the duplicated pipeline metrics.

* Make pipeline gateway metric names private as usage is purely package-internal

* Remove deprecated metrics from agent metrics test

* Make agent metric names private

* Update metrics in sample notebook to use histogram-provided ones

* Update generated Markdown version of updated notebook

* Update Markdown files generated from samples notebooks

This is the remaining changes from running 'make -C samples/ all'.
It consists of whitespace changes and some language indicators for cells.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants