Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node exporter port conflict #563

Closed
csabika7 opened this issue May 15, 2019 · 3 comments
Closed

node exporter port conflict #563

csabika7 opened this issue May 15, 2019 · 3 comments
Assignees
@gsunner
Labels
Customer Integration
Projects
0.3.0

Comments

@csabika7
Copy link

Helm chart for seldon-core-analytics includes installing a node-exporter daemonset. As it is directly uses the host network reserving the port 9100.
Deployment of this helm chart would then fail if node-exporeter have been deployed already for another application like ranch.

Do you know some way to still be able to install seldon-core-analytics which would use the already deployed node-exporter if it is already present?
@ukclivecox ukclivecox added this to the 0.2.x milestone May 15, 2019
@ukclivecox
Copy link
Contributor

Would a fix me to make that port configurable in the Helm chart values? Could you submit a PR?

@ukclivecox ukclivecox added this to To do in 0.3.0 May 24, 2019
@csabika7
Copy link
Author

csabika7 commented May 27, 2019 •
edited
Loading

Can you even do that?
In the Dockerfile of the node-exporter the 9100 port is exposed.
In the helm chart the hostNetwork is set to true.
This means in the node exporter template file I cannot set different values for the containerPort and the hostPort (e.g. containerPort: 9100, hostPort: 9101). However if I set a port other than 9100 for the containerPort then nothing will be exposed.

I could be done if hostNetwork is set to false I guess. Is there any reason for setting it to true?

@gsunner gsunner moved this from To do to In progress in 0.3.0 Jun 3, 2019
@ukclivecox ukclivecox modified the milestones: 0.2.x, 0.3.x Jun 3, 2019
@gsunner gsunner added this to To do in 0.3.1 via automation Jun 3, 2019
@gsunner gsunner removed this from In progress in 0.3.0 Jun 3, 2019
@gsunner gsunner mentioned this issue Jun 3, 2019
Closed
@csabika7 csabika7 mentioned this issue Jun 5, 2019
Merged
@ukclivecox ukclivecox removed this from To do in 0.3.1 Jun 5, 2019
@ukclivecox ukclivecox added this to In progress in 0.3.0 Jun 5, 2019
@gsunner
Copy link
Member

gsunner commented Jun 5, 2019 •
edited
Loading

merged changes in PR #617

@gsunner gsunner closed this as completed Jun 5, 2019
@gsunner gsunner moved this from In progress to Done in 0.3.0 Jun 5, 2019
agrski pushed a commit that referenced this issue Dec 2, 2022
@ukclivecox
Ensure model gateway keeps recalling scheduler and does not restart (#…
3228613 
…563)

* Ensure model gateway keeps recalling scheduler and does not restart

* update comment

* review fixes

* update go for docker file

* restructure error log message for recv fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsunner gsunner

Labels
Customer Integration
Projects
No open projects
0.3.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsunner @ukclivecox @csabika7