Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple tensorflow package from the base python seldon-core image. #564

Closed
chennupushkar opened this issue May 15, 2019 · 5 comments
Closed

Decouple tensorflow package from the base python seldon-core image. #564

chennupushkar opened this issue May 15, 2019 · 5 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone
2.0.x

Comments

@chennupushkar
Copy link

chennupushkar commented May 15, 2019 •
edited

Python Seldon-core base image comes with tensorflow package.
Decouple tensorflow package from the base python seldon-core image.
@ukclivecox
Copy link
Contributor

I think you mean the seldon-core python module includes tensorflow.
I could be a longer term aim to try to remove this dependency but we need it for:

  • gRPC handling of TensorProto payloads

@chennupushkar chennupushkar changed the title Decouple tensorflow package from the base seldon-core image. Decouple tensorflow package from the base python seldon-core image. May 15, 2019
@chennupushkar
Copy link
Author

Thank you Clive. Yes i meant seldon-core python module. Let me edit the issue.

@ukclivecox
Copy link
Contributor

The trouble is our payloads allow TensorProto whose serializaton/deserialization needs a method from Tensorflow python packagfe. Not sure we can easily change this as the Tensorflow package is a monolithic package unfortunately.

@ukclivecox ukclivecox added this to the 2.0.x milestone Aug 23, 2019
@adriangonz adriangonz mentioned this issue Oct 11, 2019
Merged
@seldondev
Copy link
Collaborator

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@seldondev seldondev added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2020
@ukclivecox
Copy link
Contributor

It is possible to install seldon-core package without tensorflow now

agrski pushed a commit that referenced this issue Dec 2, 2022
@ukclivecox
Fix static image uris (#564)
f40355b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
2.0.x
Development

No branches or pull requests
3 participants
@ukclivecox @chennupushkar @seldondev