Ambassador Swagger definition does not include namespace

[aarondav]

The generated Swagger definition linked to from these docs intended for Ambassador integration only allows providing deployment:

seldon-core/openapi/engine.oas3.json

Line 34 in 2de8086

"/seldon/{deployment}/api/v0.1/predictions": {

However, in practice it seems that both (Kubernetes) namespace and deployment are required. That is, the actual path should look like /seldon/{namespace}/{deployment}/api/v0.1/predictions.

Since Swagger HTML-escapes the input parameters, attempting to put a value for deployment like namespace/deployment gets escaped to namespace%2Fdeployment, so I think we need a second top-level parameter.

Please let me know if this proposal makes sense, or if I'm just missing something.

[ukclivecox]

Yes that makes sense. Will you submit a PR?