Add register type and some derive reflects #1
Conversation
src/portals/api.rs
Outdated
| @@ -126,15 +128,15 @@ pub enum AsPortalDestination { | |||
| } | |||
|
|
|||
| /// Portal destination to be created | |||
| #[derive(Clone, Default)] | |||
| #[derive(Clone, Reflect, FromReflect, Default)] | |||
There was a problem hiding this comment.
CreatePortalDestination and AsPortalDestination might not need it there ; I tried to add it because I wanted to register_type for CreatePortal too, but Facefrom wgpu is preventing me to do it, not sure how to fix it right now
|
Hi! As I said on discord I never used bevy_inspector_egui so I didn't know there was a need for that! About adding Reflect to CreatePortal (and its children), I'm not sure it is very useful, as this component is supposed to be deleted before the next tick in a normal scenario, but it would be useful for those scenarios where the portal doesn't get created for whatever reason (I mean, it happened to me once, so...) I guess, and it's harmless to add it I guess. What could be more useful is to add Reflect to the marker components Portal, PortalCamera and PortalDestination found in process.rs. About Face: sadly it seems that the bevy team struggles with this too, but in the meantime they're just ignoring this field and I think we should do the same until they find a solution (code is the same on main, I checked): (https://docs.rs/bevy_pbr/0.10.1/src/bevy_pbr/pbr_material.rs.html#204-207). Also, I'm curious: when bevy_inspector_egui encounters an Entity, does it automatically "link" to the entity it points to? |
|
I think Reflect for the marker components are not much useful because they don't have fields, inspector_egui displays them alright. for your curiosity: an entity encountered is nested into the field |
For compatibility with bevy_inspector_egui, this could be handy ; maybe we should consider providing it behind a feature ? I'd say it's fine like that but I'll let you judge :)