format #2
Closed
format #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to start a discussion about
cargo fmt, consider where the default is not good, whether we can configure it and/or want it.I think it's important if we ever want contributors, because a lot of rust users have
cargo fmton save so it's a bummer when we have hundreds of changes applied in this repo.There is also https://rust-lang.github.io/rustfmt/?version=v1.5.1&search=#ignore which allows us to clearly say "don't run cargo fmt", but it's unstable so it might not be a good option. We could try to bump the issue or try to contribute...