Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Allow arguments to be passed in Node flag "driver-configuration" #11367

Merged
merged 1 commit into from Dec 5, 2022

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Dec 5, 2022

Fixed #11341

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Allow arguments to be passed in Node flag "driver-configuration"

Motivation and Context

Fixes #11341.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Base: 52.83% // Head: 52.83% // No change to project coverage 👍

Coverage data is based on head (a7d90ab) compared to base (038141b).
Patch has no changes to coverable lines.

❗ Current head a7d90ab differs from pull request most recent head 027a5b5. Consider uploading reports for the commit 027a5b5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11367   +/-   ##
=======================================
  Coverage   52.83%   52.83%           
=======================================
  Files          82       82           
  Lines        5551     5551           
  Branches      198      198           
=======================================
  Hits         2933     2933           
  Misses       2420     2420           
  Partials      198      198           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujagani pujagani merged commit 21d115e into SeleniumHQ:trunk Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: JSON decoding fails on '='
2 participants