Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging levels in http.js and webdriver.js #13098

Merged
merged 2 commits into from Nov 6, 2023
Merged

Fix logging levels in http.js and webdriver.js #13098

merged 2 commits into from Nov 6, 2023

Conversation

marvinruder
Copy link
Contributor

Description

This PR replaces all invocations of the log function Logger.error(…) by Logger.severe(…).

Motivation and Context

No such function Logger.error(…) exists (see e.g.

const ALL_LEVELS = /** !Set<Level> */ new Set([
Level.OFF,
Level.SEVERE,
Level.WARNING,
Level.INFO,
Level.DEBUG,
Level.FINE,
Level.FINER,
Level.FINEST,
Level.ALL,
])
). If invoked, a TypeError: log_.error is not a function. (In 'log_.error(ex2)', 'log_.error' is undefined) is thrown.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @marvinruder!

@diemol diemol merged commit 76ace92 into SeleniumHQ:trunk Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants