Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in setup.py #13487

Merged
merged 2 commits into from Jan 23, 2024
Merged

Fix typo in setup.py #13487

merged 2 commits into from Jan 23, 2024

Conversation

EwaMarek
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #13486

Motivation and Context

To fix #13486, so that the latest selenium version installs all required dependencies.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ diemol
❌ Ewa Marek


Ewa Marek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@diemol
Copy link
Member

diemol commented Jan 23, 2024

Is there a way you can force push and make the git user match the GitHub user so the CLA accepts the contribution?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96e1411) 58.48% compared to head (7a02a92) 58.48%.
Report is 4 commits behind head on trunk.

❗ Current head 7a02a92 differs from pull request most recent head e962a84. Consider uploading reports for the commit e962a84 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13487   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files          86       86           
  Lines        5270     5270           
  Branches      220      220           
=======================================
  Hits         3082     3082           
  Misses       1968     1968           
  Partials      220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @EwaMarek!

@diemol
Copy link
Member

diemol commented Jan 23, 2024

I'll wait for the CI to finish and then I'll merge.

@EwaMarek
Copy link
Contributor Author

Thank you, @EwaMarek!

No problem!

@EwaMarek
Copy link
Contributor Author

I'll wait for the CI to finish and then I'll merge.

Thank you!

@diemol diemol merged commit 91e7572 into SeleniumHQ:trunk Jan 23, 2024
3 of 4 checks passed
@Jakub-CZ Jakub-CZ mentioned this pull request Jan 23, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Typo in setup.py
4 participants