Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong parameter name for chrome network conditions in .Net implementation #5693

Closed
KokaChernov opened this issue Mar 27, 2018 · 2 comments
Closed

Wrong parameter name for chrome network conditions in .Net implementation #5693

KokaChernov opened this issue Mar 27, 2018 · 2 comments

Comments

@KokaChernov
Copy link

From https://bugs.chromium.org/p/chromedriver/issues/detail?id=2356

Looks like wrong command parameter here:
https://github.com/SeleniumHQ/selenium/blob/selenium-3.11.0/dotnet/src/webdriver/Chrome/ChromeDriver.cs#L150

Should be spelled as 'network_conditions' instead of 'network_connection'
jimevans added a commit that referenced this issue Mar 27, 2018
@jimevans
Fixing .NET ChromeDriver network conditions commands URLs
63f65c6 
Fixes issue #5693.
@jimevans
Copy link
Member

Fixed in 63f65c6.

@KokaChernov
Copy link
Author

@jimevans thank you.

@lock lock bot locked and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimevans @KokaChernov