Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintetional inheritance of browser chrome config #610

Closed
BaluErtl opened this issue Mar 10, 2019 · 5 comments
Closed

Unintetional inheritance of browser chrome config #610

BaluErtl opened this issue Mar 10, 2019 · 5 comments

Comments

@BaluErtl
Copy link

馃挜 Selenium IDE add-on UI background color

  1. Mozilla Firefox 60.5.1esr, 64-bit (tested as Tor Browser 8.0.6 based upon this FF version)
    Selenium-ide-addon-background-color-macos-ff-tor

  2. Mozilla Firefox "Developer Edition" (formerly Aurora release channel) 66.0b14, 64-bit on Ubuntu
    Selenium-ide-addon-background-color-ubuntu-ff-deved

  3. Mozilla Firefox "Developer Edition" (formerly Aurora release channel) 66.0b14, 64-bit on macOS X
    Selenium-ide-addon-background-color-macos-ff-deved

Just for reference, this was not an issue in the "XUL-era", because that time the UI was built in a different fashion:

Selenium IDE 2.9.1.1 on Firefox 54.0.1, 64-bit:
Selenium-ide-addon-background-color-macos-old-ff

Last working version

Worked up to version: FF 60.5.1

Stopped working in version: FF 66.0b14

To Reproduce

  1. Open Mozilla Firefox's about:config panel, accept the warning message.
  2. Search for the term "background", double-click the row of browser.display.background_color and set a hexadecimal value of any dark shaded colour.
  3. Open the Selenium IDE the usual way.

Expected behavior

UI of Selenium IDE should appear on a white background, so together with the default black text color visibility of the UI supposed to be kept normal.

Project file reproducing this issue (highly encouraged)

No .side project file (SSCCE) is applicable to provide, because issue is about the UI appearance, not functionality.

Environment

OS: Ubuntu 18.04 LTS & macOS X 10.13.6
Selenium IDE Version: 3.5.8
Selenium SIDE Runner Version: n.a.
Node version: n.a.
Browser: Mozilla Firefox
Browser Version: see above

@BaluErtl
Copy link
Author

BaluErtl commented Mar 10, 2019

Regarding the possible resolutions I have the following ideas:

  1. Quickfix: define an exact hexadecimal value of a light color (probably #ffffff) in Selenium IDE's UI description files. (I'm not sure, but maybe in /packages/selenium-ide/src/neo/styles/app.css around line Use peru to get the Selenium codebase聽#20 a background-color: #FFFFFF; may help?)
  2. Long-term solution: prepare the Selenium IDE to be usable on dark background colors. This way definitely more "logic" is needed to be implemented, but a Dark theme support would offer a major feature addition to hopefully capture attention of the mainly developer audience.

@corevo
Copy link
Member

corevo commented May 13, 2019

We have no plans on adding dark mode for now, your first solution is great, do you mind sending a pr in?

@BaluErtl
Copy link
Author

Today I re-tested on mac OS by following the steps described above and now cannot reproduce anymore: in both version combinations IDE's UI appears white as expected.

  • Firefox 60.6.1esr + Selenium IDE 3.7.1
  • Firefox 67.0b18 + Selenium IDE 3.7.1

I think during the last 2 months since the reporting some CSS improvement somehow solved it.

@corevo
Copy link
Member

corevo commented May 13, 2019

Then we can close?

@BaluErtl
Copy link
Author

Sure, why not?

@lock lock bot locked and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants