Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃殌 Feature]: Java/CS FirefoxProfile to support addExtensioin temporary #10084

Closed
GregDomjan opened this issue Nov 25, 2021 · 6 comments
Closed

Comments

@GregDomjan
Copy link

GregDomjan commented Nov 25, 2021

Feature and motivation

Add to FirefoxProfile::addExtension option to add extensions as temporary

Other languages (Python, Ruby and Javascript) support providing config of adding extension as temporary
For some reason Java/C# doesn't provide config, just provides false, or nothing
https://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/firefox/AddHasExtensions.java#L105
https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/Firefox/FirefoxDriver.cs#L299

Usage example

When testing on release (non developer/nightly), an 'unsigned' xpi won't load if it isn't loaded as temporary

  • where localy signed doesn't count as signed.

On windows, when unpacking the xpi to load the folder, can lead to failures because of windows adding content like thumbs.db

		FirefoxProfile firefoxProfile = new FirefoxProfile();
		firefoxProfile.addExtension(a, true);
@github-actions
Copy link

@GregDomjan, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@GregDomjan
Copy link
Author

Python, Ruby and Javascript support, I thought we might try C# as a workaround, also found that it doesn't support temporary option
https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/Firefox/FirefoxDriver.cs#L299

@GregDomjan GregDomjan changed the title [馃殌 Feature]: Java FirefoxProfile to support addExtensioin temporary [馃殌 Feature]: Java/CS FirefoxProfile to support addExtensioin temporary Nov 25, 2021
@titusfortner
Copy link
Member

So, this feature won't be part of FirefoxProfile class, but we can add support to the driver's installAddon method.

@titusfortner
Copy link
Member

Java fixed: 932cbf9

@titusfortner
Copy link
Member

Just realized this is a duplicate of #8357. We'll track it there.

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants