New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[馃悰 Bug]: chromedriver service is not killed #10795
Comments
@gravityvi, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
@diemol i think the issue is with : https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/node/selenium-webdriver/remote/index.js#L196 We are not starting new server if a server is already existing , we just creates a new session in the existing server. So if we call quit , the server gets killed and so the error mentioned in #10499 is thrown The ideal fix seems to be to start new server or add additional flag whether to start new server or not. fix in #10499 will not kill the server. |
@diemol i was thinking if we could add a method like spawnNewService(true)
and add it as condition in remote.js start method
But i am not sure how to pass the options from node_modules/selenium-webdriver/index.js to node_modules/selenium-webdriver/remote/index.js |
The default behavior should be to span a new service for each session, and this should be transparent for the user. |
@diemol so should we remove this
|
I am not very familiar with the code details, so better please coordinate with @gravityvi who is already sending a PR. |
@praveendvd the issue is only happening with chrome service and I think it's due to this line: selenium/javascript/node/selenium-webdriver/chrome.js Lines 276 to 281 in 4ad0533
defaultService if it has been already created once.
|
@gravityvi perfect your current PR and this additional change will fix both the issues , just verified . @diemol |
i was trying like this and it was saying path not found so i ignored going to getdefaultservice: 馃槃
changing chrome to :
and
Fixes both the issues |
@gravityvi i think you have to do the same changes for all chromium based browsers not just chrome . |
@praveendvd yes will do that |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
Even after calling
driver.quit
. Not able to start chrome driver on the same port. Server is not getting killed and the port is not released.How can we reproduce the issue?
Relevant log output
Operating System
macOS Monterey
Selenium version
4.2.2
What are the browser(s) and version(s) where you see this issue?
chrome 102
What are the browser driver(s) and version(s) where you see this issue?
chromedriver 102
Are you using Selenium Grid?
No response
The text was updated successfully, but these errors were encountered: