Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃殌 Feature]: Annotate JS atoms #11038

Closed
titusfortner opened this issue Sep 16, 2022 · 1 comment
Closed

[馃殌 Feature]: Annotate JS atoms #11038

titusfortner opened this issue Sep 16, 2022 · 1 comment
Milestone

Comments

@titusfortner
Copy link
Member

Feature and motivation

We've moved several common features that used to be endpoints into atoms that get sent as large JS strings to the execute endpoint. We should prepend a comment in all the bindings for these JS executions to label what they are.

Usage example

Right now it looks like this:

"script": "return (function(){return (function(){var k=this||self;function aa(a){return\"string\"==typeof a}function.... <snip 45kb>

would be much better for it to look like:

"script": "/* isDisplayed */ return (function(){return (function(){var k=this||self;function aa(a){return\"string\"==typeof a}function.... <snip 45kb>
@titusfortner titusfortner added this to the 4.6 milestone Sep 26, 2022
@titusfortner titusfortner modified the milestones: 4.6, 4.7 Oct 17, 2022
@titusfortner titusfortner modified the milestones: 4.7, 4.8 Nov 23, 2022
@titusfortner
Copy link
Member Author

merged

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant