Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃殌 Feature]: CI should use Selenium Manager for all tests #12047

Closed
titusfortner opened this issue May 15, 2023 · 6 comments 路 Fixed by #12132
Closed

[馃殌 Feature]: CI should use Selenium Manager for all tests #12047

titusfortner opened this issue May 15, 2023 · 6 comments 路 Fixed by #12132
Assignees
Labels
A-needs new owner C-build Build related issues (bazel and CI) I-enhancement
Milestone

Comments

@titusfortner
Copy link
Member

Feature and motivation

I think our CI should delete the drivers that exist on the runners and always use Selenium Manager. I know that this means if we break Selenium Manager that none of the tests will pass, but it's essentially dog-fooding our own product, and we need something that ensures it works.

I think @diemol has an alternate proposal.

Usage example

n/a

@diemol
Copy link
Member

diemol commented May 15, 2023

I think @shs96c had some good arguments against this which I forgot.

But I would prefer to push nightly releases and run the examples we have in the docs with those nightly releases, which should then use Selenium Manager.

@titusfortner
Copy link
Member Author

Nightly releases would be awesome. How long will it take us to set that up? 馃槃

@nvborisenko
Copy link
Member

Nightly? Or when we have something new to release?..

@titusfortner
Copy link
Member Author

titusfortner commented May 16, 2023

I think ruby creates a gem every night even if nothing has changed. Could probably check if anything has changed if we need to

@diemol
Copy link
Member

diemol commented May 31, 2023

During the meeting on 25.05.2023 it was decided that we should do it, use Selenium Manager in CI by removing the env vars in GitHub runners.

Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-needs new owner C-build Build related issues (bazel and CI) I-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants