Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] add browser output from selenium manager to options #12398

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Jul 21, 2023

Status

Draft because:

Description

Sets browser location on Options class if supported (Chrome, Edge, Firefox only)

  • Errors on Chrome & Edge if browser version invalid (Not backwards compatible, but GOOD!)
  • Uses Dev/Beta/Canary/Nightly if found on system and specified by name as browser_version
  • Downloads Stable Chrome For Testing if Chrome not installed on System.

Motivation and Context

  • This ensures that the browser Selenium Manager is checking against is the one actually getting used by the driver

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1d459cd) 56.99% compared to head (94ea5e4) 56.99%.

❗ Current head 94ea5e4 differs from pull request most recent head 151b532. Consider uploading reports for the commit 151b532 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12398   +/-   ##
=======================================
  Coverage   56.99%   56.99%           
=======================================
  Files          86       86           
  Lines        5336     5336           
  Branches      193      193           
=======================================
  Hits         3041     3041           
  Misses       2102     2102           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@titusfortner titusfortner force-pushed the rb_sm_browser branch 2 times, most recently from f5e709f to 398d315 Compare July 23, 2023 18:48
@titusfortner
Copy link
Member Author

@diemol / @bonigarcia yeah, I have no idea how to do this in Java because of the crazy SeleniumManagerJsonOutput implementation. Also, I'm not sure how Java can do setBinary() in a reasonable way if the Type is Capabilities

@titusfortner titusfortner merged commit 9fdeaa9 into trunk Jul 24, 2023
26 checks passed
@titusfortner titusfortner deleted the rb_sm_browser branch July 24, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants