-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: Missing to load the "net/http" library. #12506
Conversation
What do you think about the comment I made on the previous PR? |
I think what you propose is a good idea. |
@dvarrui would you like to make the change and I'll merge it? |
OK Do I make the modification in the same "fix_dvarrui" branch or should I create a new one? |
this branch is fine. We end up squashing and merging when we accept the PR. |
Done! |
4211849
to
c80d442
Compare
This code does not need to be rebased with trunk, Github will do that automatically when it merges. I can't accept this PR without seeing the completed test run, and the results go away every time it gets rebased. 😂 |
c80d442
to
854d5d1
Compare
Body of commit message is a few lines of text, explaining things in more detail, possibly giving some background about the issue being fixed, etc. The body of the commit message can be several paragraphs, and please do proper word-wrap and keep columns shorter than about 72 characters or so. That way `git log` will show things nicely even when it is indented. Fixes #141Solve error: Missing to load the "net/http" library. Error description: Using the selenium-webdriver v4.11.0 gem results in the following error: selenium-webdriver-4.11.0/lib/selenium/webdriver/remote/http/default.rb:108:in `new_request_for': uninitialized constant S elenium::WebDriver::Remote::Http::Default::Net (NameError) req = Net::HTTP.const_get(verb.to_s.capitalize).new(url.path, headers) Solution: The problem is fixed by adding `require 'net/https'` to the `lib/selenium/webdriver/firefox.rb` file.
…ic one. moving "require 'net/http'" to "lib/selenium/webdriver.rb" so could be usedso that it can be used by all browsers
Sorry! |
It's all good, I keep forgetting to go back and look at results 😂 |
[Fix] Missing to load the "net/http" library.
Description
Get this error
Motivation and Context
Software installed:
When running this script:
Obtain this error:
Solution
Adding
require 'net/https'
to thelib/selenium/webdriver/firefox.rb
file.Types of changes
[X ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist