Node config does not see driver executable after upgrade.(Windows only)

[vveliev]

Meta -

OS: Windows 7

Selenium Version: 3.0.1

Browser: Internet explorer, chrome, firefox

Configs in Selenium -node 2.x.x-

{
  "capabilities":
      [
        {
          "browserName": "firefox",
          "maxInstances": 8,
          "version": "47",
          "platform": "WINDOWS",
          "seleniumProtocol": "WebDriver"
        },        
	{
          "browserName": "chrome",
          "maxInstances": 8,
          "version": "51",
	  "platform": "WINDOWS",
          "seleniumProtocol": "WebDriver"
        },
        {
          "browserName": "internet explorer",
          "version": "11",
          "platform": "WINDOWS",
          "maxInstances": 8,
          "seleniumProtocol": "WebDriver"
        }
      ],
  "configuration":
  {	
    "Dwebdriver.ie.driver=C://Selenium/Node/IEDriverServer32.exe": "",
    "Dwebdriver.chrome.driver=C://Selenium/Node/chromedriver.exe":"",
    "maxSession": 16,
    "port": 5555,
    "register": true,
    "registerCycle": 5000,
    "hubPort": 4444,
    "hubHost": selenium.internal.company.com
  }
}

Modified Configs for Selenium -node 3.x.x-

{
  "capabilities": [
    {
      "browserName": "firefox",
      "maxInstances": 8,
      "version": "49",
      "seleniumProtocol": "WebDriver"
    },
    {
      "browserName": "chrome",
      "maxInstances": 8,
      "version": "54",
      "seleniumProtocol": "WebDriver"
    },
        {
          "browserName": "internet explorer",
          "version": "9",
          "maxInstances": 8,
          "seleniumProtocol": "WebDriver"
        }
  ],
    "platform": "WINDOWS",
    "Dwebdriver.ie.driver=C://Selenium/Node/IEDriverServer32.exe": "",
    "Dwebdriver.chrome.driver=C://Selenium/Node/chromedriver.exe":"",
    "Dwebdriver.gecko.driver=C://Selenium/Node/geckodriver.exe":"",
    "maxSession": 16,
    "port": 5555,
    "register": true,
    "registerCycle": 5000,
    "hub": "http://selenium.internal.company.com:4444"
}

Working configuration for Selenium - node (Linux node)

{
  "capabilities": [
    {
      "browserName": "firefox",
      "maxInstances": 8,
      "version": "49",
      "seleniumProtocol": "WebDriver"
    },
    {
      "browserName": "chrome",
      "maxInstances": 8,
      "version": "54",
      "seleniumProtocol": "WebDriver"
    }
  ],
    "platform": "LINUX",
    "Dwebdriver.firefox.bin=/opt/firefox/firefox-bin": "",
    "Dwebdriver.chrome.driver=/opt/selenium/chromedriver": "",
    "Dwebdriver.gecko.driver=/opt/selenium/geckodriver":"",
    "maxSession": 8,
    "port": 5555,
    "register": true,
    "registerCycle": 5000,
    "hub": "http://selenium.internal.company.com:4444"
}

Steps to reproduce -

• Start the node
• Select any browser
  And it trows an error

10:06:49.786 WARN - Exception: The path to the driver executable must be set by
the webdriver.gecko.driver system property; for more information, see https://gi
thub.com/mozilla/geckodriver. The latest version can be downloaded from https://
github.com/mozilla/geckodriver/releases

[barancev]

This is not a proper way to pass system properties. They should be set on the command line
java -Dwebdriver.firefox.bin=/opt/firefox/firefox-bin -DDwebdriver.gecko.driver=/opt/selenium/geckodriver selenium-server.jar -role node -nodeConfig nodeConfig.json

If they used to work as described in the issue it's just a coincident but not intended behavior.