Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Memory Leak in selenium/cpp/iedriver/Script.cpp #7930

Closed
somanuell opened this issue Jan 11, 2020 · 3 comments
Closed

Small Memory Leak in selenium/cpp/iedriver/Script.cpp #7930

somanuell opened this issue Jan 11, 2020 · 3 comments
Labels
D-IE I-stale Applied to issues that become stale, and eventually closed.

Comments

@somanuell
Copy link

At line 194, the ITMLDocument2::geHt_designMode COM method is called.
That method takes an unique [out][retval] BSTR *p parameter, but the argument provided is a NOT an empty CComBSTR. The actual BSTR stored in the smart pointer is leaked.

Suggested FIX:

CComBSTR design_mode;
this->script_engine_host_->get_designMode(&design_mode);
if ( design_mode ) {
  design_mode.ToLower();
  if (design_mode == L"on") {
    CComBSTR set_design_mode = L"off";
    this->script_engine_host_->put_designMode(set_design_mode);
  }
}

OS: Windows 10
Browser: IE11

@github-actions
Copy link

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the I-stale Applied to issues that become stale, and eventually closed. label Oct 18, 2021
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as completed Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
D-IE I-stale Applied to issues that become stale, and eventually closed.
Projects
None yet
Development

No branches or pull requests

2 participants