Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error message for range mmmm.yy.dd MMMM.YY.DD when mmmm.yy.dd > MMMM.YY.DD #5

Open
hiAndrewQuinn opened this issue Apr 24, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hiAndrewQuinn
Copy link
Contributor

$ python main.py range 2024.04.23 2024.04.21

currently outputs nothing at all, and creates a nonempty cards.apkg file. This can confuse a newcomer, especially one used to the old-fashioned Unix way of "silence implies success". Much better would be something like

python main.py range 2024.04.23 2024.04.21
[Error] Start date 2024.04.23 is greater than end date 2024.04.21.

This could be implemented in the typer part of the command itself. No need to do complicated error checking logic elsewhere, this is just basic input validation.

@hiAndrewQuinn hiAndrewQuinn added enhancement New feature or request good first issue Good for newcomers labels Apr 24, 2024
@hiAndrewQuinn hiAndrewQuinn self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant