Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks.js expects error.filename #2971

Open
startswithaj opened this issue Sep 7, 2015 · 14 comments
Open

tasks.js expects error.filename #2971

startswithaj opened this issue Sep 7, 2015 · 14 comments

Comments

@startswithaj
Copy link

https://github.com/Semantic-Org/Semantic-UI/blob/master/tasks/config/tasks.js#L92

This expects that the error will have a filename property. Sometimes other errors can be thrown and caught by this.

When it tries to access error.filename.match it throws.

Cannot call method 'match' of undefined suppressing the real error.

It should be

if(error.filename && error.filename.match(/theme.less/)) {

N.B

Because semantic doesn't version its dependencies you can end up with gulp-autoprefixer 3.0.1 which requires node 12 and will make the semantic build process fail with:

/gulp-less/node_modules/accord/node_modules/when/lib/decorators/unhandledRejection.js:80
        throw e;
              ^
TypeError: Cannot call method 'match' of undefined

which is actually covering up the error:

[Error: no writecb in Transform class]

If you need to fix this force install gulp-autoprefixer to 2.3.1

@alxkolm
Copy link

alxkolm commented Sep 10, 2015

Same problem.

Fast workaround:

rm -rf node_modules/gulp-autoprefixer
npm install gulp-autoprefixer@2.3.1

@jlukic
Copy link
Member

jlukic commented Sep 10, 2015

When in doubt remove all the things.

What version of autoprefixer is causing the above errors?

@startswithaj
Copy link
Author

@jlukic gulp-autoprefixer 3.0.0 and 3.0.1 both have node 12 dependency. (running 3.0.1 on node 10 is what causes the problem). ~ This is speculation but If your not running npm version 2, I dont think npm version 1 inforces the node version dependency and allows 3.0.1 to install.

I just forced it to 2.3.1 which was the previous version my local npm was resolving prior to 3.0.1.

Someone asked I think how I forced 2.3.1; I just added gulp-autoprefixer 2.3.1 to my projects package.json which is a hackaround but because semantic will take any version its happy with this.

@jlukic
Copy link
Member

jlukic commented Sep 10, 2015

I see. Thanks for all the additional information.

I'll try to check to see if there's anything I can do against issues when running autoprefixer 3.0.

@maxiaoxiong
Copy link

@alxkolm you are right!
thanks!

@Islati
Copy link

Islati commented Mar 5, 2016

Just started using Semantic-UI in my pipeline today,and came across this issue. Installing gulp-autoprefixer@2.3.1 fixed it. Any chance of a global fix, or version update?

@r0bdiabl0
Copy link

Just hit with this bug myself, took a few days to find this issue but it fixed it. Please update, thanks!

@brandondrew
Copy link

Are we still required to use an ancient version of gulp-autoprefixer? Is there any other fix for this?

@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@Dan1ve
Copy link

Dan1ve commented Mar 8, 2018

We run into this issue, too :-( A fix would be greatly appreciated, as a downgrade of autoprefixer to some ancient version is not an option for us

@stale stale bot removed the stale label Mar 8, 2018
@stale
Copy link

stale bot commented Jun 6, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@CatalanCabbage
Copy link

CatalanCabbage commented May 13, 2020

This error still seems to be present, I encountered this in my GitLab-CI routine; any ideas on how to proceed?
I tried the workaround by @alxkolm, it didn't work. 😞
My complete error
For reference: submitted new issue on Fomantic-UI and a question on SO

Any pointers or help would be greatly appreciated!

@iamareebjamal
Copy link

Semantic UI is dead, please use fomantic UI

@CatalanCabbage
Copy link

Yup, I use Fomantic-UI; commented here just in case, since this bug has been carried over from Semantic to Fomantic.
Anyway, to anybody with this issue, for reference: a PR has been submitted with the fix, will be released in Fomantic 2.8.x :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants