Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] - vertical labeled icon grows in width with reduced size #5607

Open
levithomason opened this issue Jul 29, 2017 · 2 comments
Open

[Menu] - vertical labeled icon grows in width with reduced size #5607

levithomason opened this issue Jul 29, 2017 · 2 comments

Comments

@levithomason
Copy link
Member

levithomason commented Jul 29, 2017

Steps to Reproduce

  1. Create a vertical labeled icon menu
  2. Set size small, tiny, or mini

Expected
The Menu width should shrink to a "smaller" size.

Result
The Menu grows in width, considerably.

Fix
We are currently explicitly setting the width to larger values for vertical menus here. This makes sense, except for when icon menus are at play. In that case, we should not set any width and just let the natural width of the items dictate the width of the parent menu. A simple :not(.icon) should do it.

Compare:

image

Testcase
http://jsfiddle.net/joe2ks5w/

@awgv awgv added this to the Needs Milestone milestone Jul 29, 2017
@stale
Copy link

stale bot commented Jun 5, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Jun 5, 2018
@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants