Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tab][Label] Add the ability to use labels in tab menus #5959

Open
ocervell opened this issue Nov 17, 2017 · 5 comments
Open

[Tab][Label] Add the ability to use labels in tab menus #5959

ocervell opened this issue Nov 17, 2017 · 5 comments

Comments

@ocervell
Copy link

ocervell commented Nov 17, 2017

I want to put an inline label for one of my tabs, but not the others.
This breaks the vertical alignment between tabs, like shown below:

screen shot 2017-11-17 at 4 25 20 pm

Quick fix

Adding a circular label with class hidden to all of my tabs and hiding them using opacity css setting. This feels a little hacky though...

CSS Rules:

.ui.secondary.pointing.menu .item {
  padding-bottom: 0.5em !important;
}

.ui.secondary.pointing.menu .item .ui.fitted.circular.hidden.label {
  opacity: 0 !important;
  margin: 0px !important;
  padding: 0px !important;
  margin-left: 0px !important;
  margin-right: 0px !important;
  padding-left: 0px !important;
  padding-right: 0px !important;
  min-width: 0px !important;
}

Result:
screen shot 2017-11-17 at 5 00 31 pm

@awgv
Copy link
Member

awgv commented Nov 18, 2017

Hi @ocervell, you could set the height for all .ui.secondary.pointing.menu .item elements to fix that. What label variation do you use, is it .tiny? Inpecting the .item with the label will tell us that its height is 46px (or whatever it is in your case). The menu component doesn’t set the height, so there’s no variable in the source that we can use, so you’ll have to override it the regular way. Paste the following into installation_folder/src/site/collections/menu.overrides and rebuild the framework:

.ui.secondary.pointing.menu .item {
  min-height: 46px;
}

You can also namespace it if you don’t want to override the defaults, for example: .ui.custom.secondary.pointing.menu .item. If you want the items to be lower, change padding-bottom.

@awgv awgv closed this as completed Nov 18, 2017
@ocervell
Copy link
Author

This fix is working, yes, but shouldn't that be fixed within the framework itself ?

@awgv awgv changed the title Label on tab breaks vertical alignment [Tab][Label] Add the ability to use labels in tab menus Nov 19, 2017
@awgv
Copy link
Member

awgv commented Nov 19, 2017

@ocervell I’ll label it as enhancement.

@awgv awgv reopened this Nov 19, 2017
@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@stale stale bot closed this as completed Mar 25, 2018
@awgv awgv reopened this Mar 25, 2018
@stale stale bot removed the stale label Mar 25, 2018
@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants