-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper Class #6195
Comments
I agree this might be useful but I don't think it would be appropriate to make the class names Let me know what you think. |
Totally agree with your proposition 👍 |
If this gets added could it be included in the install as an optional component? I already have my own set of CSS utilities so I would probably opt to not include this. |
@tmentink I would imagine this would get added to |
@hammy2899 Okay that sounds good. So I have a few questions about implementation given SUI's class names:
The issue I see is having to write class names like this: You would have to ensure that the I think Bootstrap's utilities handle these situations pretty elegantly but the class names are not SUI compliant: |
@tmentink I was thinking about this as well, I was thinking of adding something like |
@tmentink : for this reason, my first suggestion but not really SUI compliant. I'm wondering if it's possible to implement it with SUI compliant and without breaking something else ^_^ |
I support the proposal |
How do you manage the case when you have a big button and small top margin like this ?
|
@hammy2899 help me to reply on Discord :
|
I'am base on bootstrap utility to write that :
|
<button type="submit" class="ui primary button mini bottom margin">
<i class="checkmark icon"></i>
{{ lang('ui_save') }}
</button> Unfortunately the word mini and similar other affect the size of buttons at least. |
@dutrieux I suggestion for rewording your example for avoiding unwanted style influences: |
Is this worked on by someone??? |
Can SUI offering margin / padding class like :
where 0 < x < 15 representing size margin / padding ?
Combining this with "computer", "tablet" allow us to define dynamic margin about device.
I don't know if my suggestion is SUI "compatible" but this already exists in others frameworks and is very usefull to adjust UI without specific CSS.
The text was updated successfully, but these errors were encountered: