Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] with detachable=false is not working with 2.3 #6206

Closed
ZyoxNet opened this issue Feb 23, 2018 · 12 comments
Closed

[Modal] with detachable=false is not working with 2.3 #6206

ZyoxNet opened this issue Feb 23, 2018 · 12 comments
Milestone

Comments

@ZyoxNet
Copy link

ZyoxNet commented Feb 23, 2018

Hi,

with 2.3 the undetachable modal is not working correctly anymore.

See https://jsfiddle.net/ca0rovs3/221/

@foreveRush
Copy link

Hi, I also have css issue with Controlled modal... After updating to version 2.3

@ghost
Copy link

ghost commented Feb 27, 2018

$('.ui.tiny.modal').modal({detachable: false, centered: true }).modal('show');

If detachable:false is removed, then the modal is displayed in the center. Otherwise it aligns itself on the top right.
Has anyone found a fix yet?

@jlukic jlukic added this to the 2.3.1 milestone Feb 28, 2018
@jlukic
Copy link
Member

jlukic commented Feb 28, 2018

I'll look at this in patch.

@jlukic jlukic modified the milestones: 2.3.1, 2.3.2 Mar 19, 2018
@hluz
Copy link

hluz commented May 18, 2018

bump!

@jlukic jlukic modified the milestones: 2.3.2, 2.3.3 Jun 18, 2018
@Jielde
Copy link

Jielde commented Jun 20, 2018

does not work with patch 2.3.2 :(

@ShawnTheBeachy
Copy link

Ugh... This bug just brought development of one of my pages to a grinding halt.

@ghost
Copy link

ghost commented Jul 10, 2018

@tastesliketurkey
If your page does not postback and you have all the data pulled using ajax, you can just avoid having detachable false

@ShawnTheBeachy
Copy link

@manasilele Yeah, I need to post back, and the modal contains data I need. 🙁 I got around it by just manually rendering the dimmer and modal where I want them, but it still would have been nice to stick with the default implementation.

@ghost
Copy link

ghost commented Jul 10, 2018

@TastesLikeTurkey does it align in the center though?

@ShawnTheBeachy
Copy link

ShawnTheBeachy commented Jul 10, 2018

Do you mean now that I'm rendering it manually? If so, then yes. Here's what I'm doing:

// Inside my form. I'm using Razor Pages, so this is not rendered if the modal shouldn't be shown,
// but you could also use JavaScript to control the visibility.
<div class="ui dimmer modals active" style="position:fixed;">
    <div class="ui active modal">
        // Modal content
    </div>
</div>

@AlexanderZnaydyuk
Copy link

AlexanderZnaydyuk commented Jul 11, 2018

I spent a whole day trying to fix my modals and bugs caused by 2.3 version of semantic.

The best solution at the moment is to make a rollback to 2.2.

npm install semantic-ui@2.2.14
gulp build

Modals are fixed, labels displayed correctly.

@jlukic jlukic modified the milestones: 2.3.3, 2.3.4 Sep 3, 2018
@jlukic jlukic closed this as completed Sep 3, 2018
@melkalakhi
Copy link

melkalakhi commented Jul 28, 2020

Try this :
$('#your-modal-id').modal({ useFlex: false}).modal("show");
$('.ui.dimmer.modals').appendTo('#your-form-id');
$('.ui.dimmer.modals').css('overflow', 'scroll');
$('#your-modal-id').css('position', 'relative');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants