Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Close button on the modal doesn't show in the viewport for certain window sizes #6352

Open
robespmun opened this issue Apr 25, 2018 · 2 comments

Comments

@robespmun
Copy link

Coming from: Semantic-Org/Semantic-UI-React#2728

Steps

Use a 'large' size Modal and resize the window.

Expected Result

The close button should be shown inside or outside the modal depending on the size of the window, but never outside of the viewport.

Actual Result

There are some window sizes that make the close icon display outside of the modal but not inside the viewport.

Version

2.2.13

Testcase
https://codesandbox.io/s/jvw9rzmm5y

Play around with the width between 1040 and 990.

@y0hami
Copy link
Member

y0hami commented Apr 25, 2018

I think this needs some discussion because this shouldn't affect users since there isn't a device using a resolution of this sort.

If you know of a device in the resolution please let me know.

@marcellomontemagno
Copy link

@hammy2899 I wouldn't rely on standard window sizing, users might have their browser window resized to any non standard breakpoint for any kind of reason and this has been an issue for me in many occasions in my daily usage of my app.

As an extra info this happens both if you resize your browser window horizontally or vertically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants