Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not embed GFont, to comply with GDPR #6422

Open
geek-merlin opened this issue Jun 2, 2018 · 7 comments
Open

Should not embed GFont, to comply with GDPR #6422

geek-merlin opened this issue Jun 2, 2018 · 7 comments

Comments

@geek-merlin
Copy link

Title: Should not hard embed GFont, to comply with GDPR

In germany we have first GDPR cease-and-desist(-and-pay) letters for GFonts, so they should not be embedded.

Steps

Use and view a page.

Expected Result

Must not embed external assets.

Actual Result

@import url('https://fonts.googleapis.com/css?family=Lato:400,700,400italic,700italic&subset=latin');

Version

current master

Testcase

n/a

@hmaesta
Copy link

hmaesta commented Jun 7, 2018

You can disable loading fonts from Google Fonts by setting @importGoogleFonts: false on your theme's site.variables

For example, on line 16 of default theme.

@geek-merlin
Copy link
Author

Thanks!

It looks that you have to do a complete build yourself then?

@hmaesta
Copy link

hmaesta commented Jun 7, 2018

Yes, you have.
That's a easier way of building just the CSS with LESS-only distribution

@j5k
Copy link

j5k commented Jun 18, 2018

Or download the css and fonts from google to local and remove the import line from the css file

@jlukic
Copy link
Member

jlukic commented Jun 18, 2018

I generally use fonts from latofonts.com and skip the import when building custom builds myself.

@kaisbensalah
Copy link

kaisbensalah commented Sep 25, 2018

Apart from GDPR, and as I pointed out in the issue #6599, importing the fonts via HTTP will affect UI loading performance, and increase latency. The method used for importing google fonts results in extremely annoying behavior. I think this issue needs more attention.

@kaisbensalah
Copy link

kaisbensalah commented Sep 25, 2018

Why not include the google fonts along with the source code resources, instead of forcing the library to fetch them externally each time when being loaded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants