Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] list icon in "ui list" context has wrong padding #6437

Open
mguentner opened this issue Jun 17, 2018 · 4 comments
Open

[List] list icon in "ui list" context has wrong padding #6437

mguentner opened this issue Jun 17, 2018 · 4 comments

Comments

@mguentner
Copy link

Steps

  1. Use <div class="ui list"> or <div class="list">
  2. Use <i class="list icon"></i> for an item

Expected Result

list icon has same padding / offset as others

Actual Result

list icon has weird padding / offset

Version

2.3.1

Testcase

https://jsfiddle.net/8prnh2ym/

@iHaPBoy
Copy link

iHaPBoy commented Jul 25, 2018

list alternate outline icon has the same problem.

@merowinger92
Copy link

https://jsfiddle.net/etx57bur/7/

@laliluna
Copy link

laliluna commented Oct 31, 2018

The reason for the problem is a collision between class name "list" with a icon named "list".
The approach to fix this by making the list selector more specific (#6510) fixes this only for the current situation. We could run into random collisions in the future when new icons appear in font awesome.
An alternative is to prefix icons in general, which would solve this once and for all. This carries the trade off that we would probably need to support both icon class names for a while.

<i class="ui-list icon"> instead of <i class="list icon">

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants