Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tab] should escape meta characters before sending to jquery #6750

Open
ellemenno opened this issue Feb 17, 2019 · 3 comments
Open

[Tab] should escape meta characters before sending to jquery #6750

ellemenno opened this issue Feb 17, 2019 · 3 comments

Comments

@ellemenno
Copy link

When tabPath is sent to jQuery in tab.js#L382, it does not escape meta characters such as !"#$%&'()*+,./:;<=>?@[]`{|}~, which can result in uncaught errors.

e.g. kramdown creates footnote fragment links in the format #fn:4, which results in the following error from tab.js+jQuery:

Uncaught Error: Syntax error, unrecognized expression: unsupported pseudo: 4

According the the jQuery docs, meta characters should be escaped via double backslashes (\\): http://api.jquery.com/category/selectors/

@ellemenno
Copy link
Author

jsfiddle to reproduce issue: https://jsfiddle.net/ellemenno/f1tdw9pm/

@lubber-de

This comment was marked as spam.

@ellemenno
Copy link
Author

@lubber-de —thanks, that was fast!

It looks like FUI also has a supported SASS distro? hmm.. i'll look at this project more closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants