Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] - Icon Button Group Should center icon inside button #4487

Closed
Chris-R3 opened this issue Aug 27, 2016 · 3 comments
Closed

[Button] - Icon Button Group Should center icon inside button #4487

Chris-R3 opened this issue Aug 27, 2016 · 3 comments
Labels
Confirmed Bug High Priority
Milestone
2.2.8

Comments

@Chris-R3
Copy link

icons inside an icon button group appear off-center

example in button docs

the issue seems to be located here:

// src/definitions/elements/button.less:594
.ui.button:not(.icon) > .icon:not(.button):not(.dropdown) {
  margin: @iconMargin;
}
@Chris-R3 Chris-R3 changed the title [Button]-Icon Button Group Should center icon inside button [Button] - Icon Button Group Should center icon inside button Aug 27, 2016
@jlukic
Copy link
Member

jlukic commented Aug 29, 2016

This is a regression that occurred sometime recently. I'll try to address shortly.

@jlukic jlukic modified the milestones: 2.2.4, 2.2.5 Aug 29, 2016
@jlukic jlukic modified the milestones: 2.2.5, 2.2.6, 2.2.7 Oct 28, 2016
@jlukic
Copy link
Member

jlukic commented Dec 29, 2016

Wow I suck, fixed in 2.2.8 4a4fc9b

@jlukic jlukic closed this as completed Dec 29, 2016
@ghost
Copy link

ghost commented Dec 9, 2017

how can I add font awesome icon ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug High Priority
Projects
None yet
Milestone
2.2.8
Development

No branches or pull requests
2 participants
@jlukic @Chris-R3