Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Error when approving a wiki page #23

Open
AID-PMBD opened this issue Oct 20, 2021 · 3 comments
Open

Internal Error when approving a wiki page #23

AID-PMBD opened this issue Oct 20, 2021 · 3 comments

Comments

@AID-PMBD
Copy link

Setup and configuration

  • SMW version: 3.2.3
  • SAR version: 0.1-alpha (8e30af0)
  • MW version: 1.35.3
  • DB (MySQL etc.): MySQL 8.0.26-0ubuntu0.20.04.3
  • ApprovedRevs version: 1.6

Issue

When trying to approve a version of a page the following error appears:

[3c3c2a4e30d14bce2eb59797] /pmbd/index.php?title=Approvetest&action=approve&oldid=1358 TypeError from line 68 of /var/www/html/pmbd/extensions/SemanticApprovedRevs/src/ApprovedRevsHandler.php: Argument 2 passed to SMW\ApprovedRevs\ApprovedRevsHandler::doChangeRevision() must be an instance of MediaWiki\Revision\RevisionStoreRecord or null, object given, called in /var/www/html/pmbd/extensions/SemanticApprovedRevs/src/Hooks.php on line 176

Backtrace:

#0 /var/www/html/pmbd/extensions/SemanticApprovedRevs/src/Hooks.php(176): SMW\ApprovedRevs\ApprovedRevsHandler->doChangeRevision()
#1 /var/www/html/pmbd/includes/HookContainer/HookContainer.php(329): SMW\ApprovedRevs\Hooks->onChangeRevision()
#2 /var/www/html/pmbd/includes/HookContainer/HookContainer.php(132): MediaWiki\HookContainer\HookContainer->callLegacyHook()
#3 /var/www/html/pmbd/includes/Hooks.php(137): MediaWiki\HookContainer\HookContainer->run()
#4 /var/www/html/pmbd/extensions/SemanticMediaWiki/src/MediaWiki/HookDispatcher.php(251): Hooks::run()
#5 /var/www/html/pmbd/extensions/SemanticMediaWiki/src/MediaWiki/RevisionGuard.php(174): SMW\MediaWiki\HookDispatcher->onChangeRevision()
#6 /var/www/html/pmbd/extensions/SemanticMediaWiki/includes/ContentParser.php(200): SMW\MediaWiki\RevisionGuard->getRevision()
#7 /var/www/html/pmbd/extensions/SemanticMediaWiki/includes/ContentParser.php(144): SMW\ContentParser->getRevision()
#8 /var/www/html/pmbd/extensions/SemanticMediaWiki/includes/ContentParser.php(128): SMW\ContentParser->fetchFromContent()
#9 /var/www/html/pmbd/extensions/SemanticMediaWiki/src/MediaWiki/Hooks/LinksUpdateConstructed.php(153): SMW\ContentParser->parse()
#10 /var/www/html/pmbd/extensions/SemanticMediaWiki/src/MediaWiki/Hooks/LinksUpdateConstructed.php(143): SMW\MediaWiki\Hooks\LinksUpdateConstructed->reparseAndFetchSemanticData()
#11 /var/www/html/pmbd/extensions/SemanticMediaWiki/src/MediaWiki/Hooks/LinksUpdateConstructed.php(97): SMW\MediaWiki\Hooks\LinksUpdateConstructed->updateSemanticData()
#12 /var/www/html/pmbd/extensions/SemanticMediaWiki/src/MediaWiki/Hooks.php(879): SMW\MediaWiki\Hooks\LinksUpdateConstructed->process()
#13 /var/www/html/pmbd/includes/HookContainer/HookContainer.php(329): SMW\MediaWiki\Hooks->onLinksUpdateConstructed()
#14 /var/www/html/pmbd/includes/HookContainer/HookContainer.php(132): MediaWiki\HookContainer\HookContainer->callLegacyHook()
#15 /var/www/html/pmbd/includes/HookContainer/HookRunner.php(2380): MediaWiki\HookContainer\HookContainer->run()
#16 /var/www/html/pmbd/includes/deferred/LinksUpdate.php(175): MediaWiki\HookContainer\HookRunner->onLinksUpdateConstructed()
#17 /var/www/html/pmbd/extensions/ApprovedRevs/includes/ApprovedRevs.php(551): LinksUpdate->__construct()
#18 /var/www/html/pmbd/extensions/ApprovedRevs/includes/ARApproveAction.php(39): ApprovedRevs::setApprovedRevID()
#19 /var/www/html/pmbd/includes/MediaWiki.php(527): ARApproveAction->show()
#20 /var/www/html/pmbd/includes/MediaWiki.php(313): MediaWiki->performAction()
#21 /var/www/html/pmbd/includes/MediaWiki.php(940): MediaWiki->performRequest()
#22 /var/www/html/pmbd/includes/MediaWiki.php(543): MediaWiki->main()
#23 /var/www/html/pmbd/index.php(53): MediaWiki->run()
#24 /var/www/html/pmbd/index.php(46): wfIndexMain()
#25 {main}
@gesinn-it-gea
Copy link
Member

try to use SMW dev-master if you need MW 1.35 or alternatively MW 1.31 with SMW 3.2.3

@AID-PMBD
Copy link
Author

Thank you, installing the dev-master solved the issue for me. I am now using SMW 4.0.0-alpha (e7a67a1)

@AID-PMBD AID-PMBD reopened this Oct 29, 2021
@AID-PMBD
Copy link
Author

Sorry, I installed Semantic Approved Revs last week, but didn't get to testing it. It shows up in my Special Page:Version, but it doesn't create the properties as shown in the demonstration Video.

Is there an additional step I have to go trough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants