Skip to content
This repository has been archived by the owner on Mar 29, 2019. It is now read-only.

OpenLayers result format auto-zoom is broken #80

Closed
kghbln opened this issue Jul 15, 2016 · 16 comments · Fixed by ProfessionalWiki/Maps#234
Closed

OpenLayers result format auto-zoom is broken #80

kghbln opened this issue Jul 15, 2016 · 16 comments · Fixed by ProfessionalWiki/Maps#234
Labels

Comments

@kghbln
Copy link
Member

kghbln commented Jul 15, 2016

No results are rendered then searching for results with

{{#ask:
 [[Category:Sample pages]]
 |?Has coordinates
 |format=openlayers
}}

whereas format=googlemaps shows the expected results. See on the example page on sandbox.smw.

@PeterTheOne
Copy link
Member

The map shows results, it is just zoomed into the ocean and not centered correctly.

@kghbln
Copy link
Member Author

kghbln commented Aug 2, 2016

The map shows results, it is just zoomed into the ocean and not centered correctly.

Ah, this used to be the behaviour when no results were found. So I did not look further. So the autozooming appears somehow broken?

@PeterTheOne
Copy link
Member

Seems so.

@JeroenDeDauw
Copy link
Member

Can it be that the OL format was disabled on the sandbox for some reason? It's not showing up on Special:Ask, and this would explain why its falling back to google maps.

@kghbln
Copy link
Member Author

kghbln commented Aug 16, 2016

No, the settings in "LocalSettings.php" on sandbox:

## Maps
// Composer
$egMapsEnableCategory = false;

## SemanticMaps
// Composer

@JeroenDeDauw
Copy link
Member

Does this issue also happen on other wikis? My guess is still that the format is not enabled. Perhaps some code change accidentally broke registration of the thing?

@PeterTheOne
Copy link
Member

On my development wiki I have the same issue for some time now.

@mwjames
Copy link
Contributor

mwjames commented Aug 16, 2016

MapsMappingServices::registerServiceFeature( 'openlayers', 'qp', 'SMMapPrinter' );

Above is missing in [0], somehow it got lost between merges (see [1]).

[0] https://github.com/SemanticMediaWiki/SemanticMaps/blob/master/src/services/OpenLayers/SM_OpenLaysers.php

[1] 5e097c0#diff-0b3bd45d437aca0dfa0e5dfc6b1caafbR73

@PeterTheOne
Copy link
Member

PR incoming ;)

@JeroenDeDauw
Copy link
Member

@kghbln do you still see this issue?

@kghbln
Copy link
Member Author

kghbln commented Sep 1, 2016

do you still see this issue?

Dunno, since currently "openlayers" renders as "googlemaps" due to #77

@JeroenDeDauw JeroenDeDauw changed the title format "openlayers" does not render results OpenLayers result format auto-zoom is broken Sep 13, 2016
@JeroenDeDauw
Copy link
Member

Anyone know if this is a regression since 3.3, or did that release also include the bug?

@PeterTheOne
Copy link
Member

@JeroenDeDauw As far as I know this bug was not present in 3.3 and it is likely that I introduced it somewhere along the way ^^

@PeterTheOne
Copy link
Member

This bug applies also to Maps display_map with more than one point. Also I don't understand how this has worked before..

@PeterTheOne
Copy link
Member

It worked in Maps 3.6

@PeterTheOne
Copy link
Member

PR incoming ^^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants