Empty (or invalid) dataValue in InTextAnnotationParser creates property reference

[mwjames]

[0] shows that despite being empty (with an error message) [[EmptyDataValueCreatesProperty:: ]] still creates a property reference entry in the ID_TABLE [1].

The issue is to check for validity:

-           if ( $this->isEnabledNamespace && $this->isAnnotation ) {
+           if ( $dataValue->isValid() && $this->isEnabledNamespace && $this->isAnnotation ) {
                $this->parserData->addDataValue( $dataValue );
            }

[0] http://sandbox.semantic-mediawiki.org/wiki/EmptyDataValueCreatesProperty

[1] http://sandbox.semantic-mediawiki.org/w/index.php?title=Special%3AProperties&property=EmptyDataValueCreatesProperty

[mwjames]

-           if ( $this->isEnabledNamespace && $this->isAnnotation ) {
+           if ( $dataValue->isValid() && $this->isEnabledNamespace && $this->isAnnotation ) {
                $this->parserData->addDataValue( $dataValue );
            }

If we check for $dataValue->isValid() as mentioned above then of course we loose the ability to filter on Has improper value for as an invalid DataValue which creates an error annotation with reference to the property that caused the issue.

[mwjames]

Instead of changing the InTextAnnotationParser behaviour we keep the workflow as-is and rely on the post-processing (#1216) to remove outdated references.