Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$smwgLinksInValue leading to PHP crashes when set to "true" #1963

Closed
kghbln opened this issue Oct 26, 2016 · 4 comments
Closed

$smwgLinksInValue leading to PHP crashes when set to "true" #1963

kghbln opened this issue Oct 26, 2016 · 4 comments

Comments

@kghbln
Copy link
Member

kghbln commented Oct 26, 2016

Setup and configuration

  • Semantic MediaWiki: 2.5.0-alpha (9a82356)
  • MediaWiki: 1.27.1 (a52d35d)
  • PHP: 5.6.27
  • MariaDB: 10.0.27

Issue

The help page on $smwgLinksInValues still warns about possible PHP crashes if set the configuration parameter is set to "true" due to an eight year old warning.

Quote @mwjames:

So it is time to reevaluate the truthfulness of this statement or at least given an indication of how many links would break the wiki. For example a text with xyz characters and x amount of links in values would break the wiki for the PCRE y version.

It is however now possible to avoid changing this setting by using the #set' parser function as these examples show but what about in-text annotations?

To be able to test I have changed the configruation of sandbox to $smwgLinksInValues = true;.

A test page for this issue can be found here.

@kghbln
Copy link
Member Author

kghbln commented Oct 26, 2016

On the spot which caused #1961 (comment) to exit I get this in the promt:

(3371/3427)     Finished processing ID 3376 (Utilisateur:Lalquier)
(3373/3427)     Finished processing ID 3378 (This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_by_Semantic_MediaWiki._For_a_comprehensive_description_on_how_to_use_annotations_or_the#0#ask_parser_function,_please_have_a_look_at_the_getting_started,_in-text_annotation,_or_inline_queries_help_page.This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_)
(3374/3427)     Finished processing ID 3379 (Utilisateur:Emilzola)
(3378/3427)     Finished processing ID 3401 (Subobject_and_"best"_value_query#0#_QUERYcd0dd34fd10ddcd0907e4b6a34e98dfd)
(3379/3427)     Finished processing ID 3402 (Subobject_and_"best"_value_query#0#_QUERY5ee3d99470eef1e74c20c3fd9f5eeb48)
(3380/3427)     Finished processing ID 3403 (Subobject_and_"best"_value_query#0#_QUERY5d5addc5ff705e4301fa60f45f3fafa3)
(3381/3427)     Finished processing ID 3404 (SEA:Internal#0#_QUERYc14b0a6b4f5c29750d69874553aaf8d3)
(3382/3427)     Finished processing ID 3405 (SEA:Internal#0#_QUERYc62ef87cee27cd0afd3f6a2ad07efd95)
(3383/3427)     Finished processing ID 3406 (This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_by_Semantic_MediaWiki._For_a_comprehensive_description_on_how_to_use_annotations_or_the#0#ask_parser_function,_please_have_a_look_at_the_getting_started,_in-text_annotation,_or_inline_queries_help_page.This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_)
(3392/3427)     Finished processing ID 3428 (This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_by_Semantic_MediaWiki._For_a_comprehensive_description_on_how_to_use_annotations_or_the#0#ask_parser_function,_please_have_a_look_at_the_getting_started,_in-text_annotation,_or_inline_queries_help_page.This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_)
(3412/3427)     Finished processing ID 3448 (This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_by_Semantic_MediaWiki._For_a_comprehensive_description_on_how_to_use_annotations_or_the#0#ask_parser_function,_please_have_a_look_at_the_getting_started,_in-text_annotation,_or_inline_queries_help_page.This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_)

This does not really look healthy.

@mwjames
Copy link
Contributor

mwjames commented Oct 26, 2016

(3373/3427) Finished processing ID 3378 (This_page_supports_semantic_in-text_annotations_(e.g._"Is_specified_asWorld_Heritage_Site")_to_build_structured_and_queryable_content_provided_by_Semantic_MediaWiki._For_a_comprehensive_description_on_how_to_use_annotations_or_the#0#ask_parser_function,_please_have_a_look_at_the_getting_started,in-text_annotation,or_inline_queries_help_page.This_page_supports_semantic_in-text_annotations(e.g."Is_specified_asWorld_Heritage_Site")to_build_structured_and_queryable_content_provided)

This is the text shown above the the Edit window, so yes this looks strange (well the message text contains [[ .. ]] links).

@kghbln
Copy link
Member Author

kghbln commented Oct 26, 2016

This is the text shown above the the Edit window, so yes this looks strange (well the message text contains [[ .. ]] links).

Though not the nicest outcome but still a good to know thing what may be worked upon at some time. Anther insight from this: using #set works.

@kghbln
Copy link
Member Author

kghbln commented Oct 26, 2016

So the answer is "yes" the issue is still there with recent versions of PCRE though showing a different behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants