Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class 'SMW\Parser\linksProcessor' not found #2223

Closed
s7eph4n opened this issue Feb 3, 2017 · 4 comments
Closed

Class 'SMW\Parser\linksProcessor' not found #2223

s7eph4n opened this issue Feb 3, 2017 · 4 comments
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error

Comments

@s7eph4n
Copy link
Contributor

s7eph4n commented Feb 3, 2017

Setup and configuration

  • SMW version: 2.5.0-alpha (886138d) 16:47, 30 January 2017
  • MW version: 1.29.0-alpha (ec84fa3) 20:04, 3 February 2017
  • PHP version: 7.0.13-0ubuntu0.16.04.1 (apache2handler)
  • DB: MySQL 5.7.17-0ubuntu0.16.04.1

Issue

Produces a stack trace and outputs:

[6e49e811e0af67948049790a] /w/index.php/Special:SearchByProperty/:Alternate-20name/Aarschot Error from line 266 of /home/stephan/website/mw/extensions/SemanticMediaWiki/src/InTextAnnotationParser.php: Class 'SMW\Parser\linksProcessor' not found

Backtrace:

#0 /home/stephan/website/mw/extensions/SemanticMediaWiki/src/Parser/Obfuscator.php(108): SMW\InTextAnnotationParser::getRegexpPattern(boolean)
#1 /home/stephan/website/mw/extensions/SemanticMediaWiki/src/InTextAnnotationParser.php(209): SMW\Parser\Obfuscator::removeAnnotation(string)
#2 /home/stephan/website/mw/extensions/SemanticMediaWiki/includes/storage/SMW_ResultArray.php(205): SMW\InTextAnnotationParser::removeAnnotation(string)
#3 /home/stephan/website/mw/extensions/SemanticMediaWiki/src/MediaWiki/Specials/SearchByProperty/QueryResultLookup.php(139): SMWResultArray->getNextDataValue()
#4 /home/stephan/website/mw/extensions/SemanticMediaWiki/src/MediaWiki/Specials/SearchByProperty/PageBuilder.php(189): SMW\MediaWiki\Specials\SearchByProperty\QueryResultLookup->doQueryForNearbyResults(SMW\MediaWiki\Specials\SearchByProperty\PageRequestOptions, integer, boolean)
#5 /home/stephan/website/mw/extensions/SemanticMediaWiki/src/MediaWiki/Specials/SearchByProperty/PageBuilder.php(161): SMW\MediaWiki\Specials\SearchByProperty\PageBuilder->getNearbyResults(array, integer)
#6 /home/stephan/website/mw/extensions/SemanticMediaWiki/src/MediaWiki/Specials/SearchByProperty/PageBuilder.php(78): SMW\MediaWiki\Specials\SearchByProperty\PageBuilder->getResultHtml()
#7 /home/stephan/website/mw/extensions/SemanticMediaWiki/src/MediaWiki/Specials/SpecialSearchByProperty.php(72): SMW\MediaWiki\Specials\SearchByProperty\PageBuilder->getHtml()
#8 /home/stephan/website/mw/includes/specialpage/SpecialPage.php(522): SMW\MediaWiki\Specials\SpecialSearchByProperty->execute(string)
#9 /home/stephan/website/mw/includes/specialpage/SpecialPageFactory.php(576): SpecialPage->run(string)
#10 /home/stephan/website/mw/includes/MediaWiki.php(284): SpecialPageFactory::executePath(Title, RequestContext)
#11 /home/stephan/website/mw/includes/MediaWiki.php(859): MediaWiki->performRequest()
#12 /home/stephan/website/mw/includes/MediaWiki.php(520): MediaWiki->main()
#13 /home/stephan/website/mw/index.php(43): MediaWiki->run()
#14 {main}

Steps to reproduce the observation (recommendation is to use the sandbox):
see e.g. https://sandbox.semantic-mediawiki.org/wiki/Sp%C3%A9cial:Recherche_par_propri%C3%A9t%C3%A9/:Age/10

@s7eph4n s7eph4n added the bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error label Feb 3, 2017
@JeroenDeDauw
Copy link
Member

#2224

@mwjames
Copy link
Contributor

mwjames commented Feb 4, 2017

[6e49e811e0af67948049790a] /w/index.php/Special:SearchByProperty/:Alternate-20name/Aarschot Error from line 266 of /home/stephan/website/mw/extensions/SemanticMediaWiki/src/InTextAnnotationParser.php: Class 'SMW\Parser\linksProcessor' not found

I'm sorry for the inconvenience and while I try to be careful when refactoring classes (#2214) those things will continue to happen until our test environment is failing in those cases.

With ~4300 tests at bay, none of them caught the issue (and it should have, if not at all by this [0] one), anyway thanks for testing and saving us from some embarrassing moments.

#2224

Thanks

[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/Integration/JSONScript/TestCases/s-0002.json

@mwjames
Copy link
Contributor

mwjames commented Feb 4, 2017

Steps to reproduce the observation (recommendation is to use the sandbox):
see e.g. https://sandbox.semantic-mediawiki.org/wiki/Sp%C3%A9cial:Recherche_par_propri%C3%A9t%C3%A9/:Age/10

Fixed for the cited example.

@mwjames mwjames closed this as completed Feb 4, 2017
@s7eph4n
Copy link
Contributor Author

s7eph4n commented Feb 4, 2017

That was fast. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error
Projects
None yet
Development

No branches or pull requests

3 participants