Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade from MW 1.39.4 to 1.39.5 new deprecation messages (SRF) and (PF) run query no longer providing drop down list #5570

Open
pav00 opened this issue Dec 16, 2023 · 4 comments
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error

Comments

@pav00
Copy link

pav00 commented Dec 16, 2023

Setup

  • SMW version: 4.1.2
  • Semantic Result Formats 4.2.0
  • Page Forms 5.6.3
  • MediaWiki 1.39.5
  • PHP 8.1.23 (fpm-fcgi)
  • MariaDB 11.1.2-MariaDB
  • ICU 73.2
  • LilyPond 2.22.2
  • Elasticsearch 7.10.2

Issue

Testing of SMW under 1.39.4 was successful and the last step before SMW install in production was testing how troublesome the process of upgrading MW would be. After the upgrade and all scripts finished there are unfortunately issues:

  1. New deprecation messages:
    Deprecated: Premature access to service container [Called from SemanticResultFormats::registerHooks in .../SemanticResultFormats/SemanticResultFormats.php at line 56] in .../includes/debug/MWDebug.php on line 381

Deprecated: Premature access to service 'HookContainer' [Called from MediaWiki\MediaWikiServices::getInstance in .../includes/MediaWikiServices.php at line 289] in .../includes/debug/MWDebug.php on line 381

Deprecated: Premature access to service 'ObjectFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in .../includes/ServiceWiring.php at line 721] in .../includes/debug/MWDebug.php on line 381

  1. Page Forms run query (using input type=combobox) no longer provides drop down list, just circle, worked fine in 1.39.4.

  2. Semantic Mediawiki install prevents Special:Search and Special:RecentChanges from fully loading. When SemanticMediaWiki, SemanticResultFormats and PageForms extensions are disabled, Special:Search and Special:RecentChanges load normally.

Unable to resolve these issues on my own.

@pav00 pav00 added the bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error label Dec 16, 2023
@krabina
Copy link
Contributor

krabina commented Dec 18, 2023

See also SemanticMediaWiki/SemanticResultFormats#781
You you try to just deativate PageForms and see wheter 3. still exists?
I don't think so, since https://test.knowledge.wiki/Spezial:Letzte_%C3%84nderungen?hidebots=1&limit=500&days=30&enhanced=1&urlversion=2 is working.

@pav00
Copy link
Author

pav00 commented Dec 18, 2023

Actually PageForms is off the hook, SRF looks like a culprit. I ran three tests:

SemanticMediaWiki - enabled, SemanticResultFormats - disabled, PageForms - disabled

Special:Search and Special:RecentChanges load normally. Deprecated messages disappear, unfortunately Semantic result formats functionality (valuerank format) and Pageforms (RunQuery) as well.

SemanticMediaWiki - enabled, SemanticResultFormats - enabled, PageForms - disabled

Special:Search and Special:RecentChanges do not load normally. Deprecated messages appear.

SemanticMediaWiki - enabled, SemanticResultFormats - disabled, PageForms - enabled

Special:Search and Special:RecentChanges load normally, also RunQuery works normally.

I restarted server and all caches for all tests.

@krabina
Copy link
Contributor

krabina commented Dec 19, 2023

There are two aspects: First the deprectation notices. If you don't want to see them, you can comment out the displaying of errors

#error_reporting( E_ALL );
#ini_set( 'display_errors', 1 );

The other aspect is Special:RecentChanges not loading. I have seen this once in a wiki (in 1.35, though). I have never seen the same problem in Special:Search.

Does it look like this (page is loading, except for the area where the filters are supposed to be)?
image

This could be realted to some incimpatibility with another extension.
Can you do one more test where everything is disabled except for SMW and SRF?

@pav00
Copy link
Author

pav00 commented Dec 19, 2023

Yes, the picture corresponds to the issue:
Normal:
SMW_rc_normal_20231219191713
SMW_search_normal_20231219191713

Abnormal:
SMW_rc_abnormal_20231219191713
SMW_search_abnormal_20231219191713

The test with all the extensions disabled except SMW and SRF was done, issue persists. (Once Elastica, AdvancedSearch and
CirrusSearch were disabled and search services are not available, only RecentChanges issue can be observed).

Used formats from SRF: valuerank, array, listwidget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error
Projects
None yet
Development

No branches or pull requests

3 participants
@krabina @pav00 and others