Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of deprecated ResultPrinter::getParameters #1654

Closed
JeroenDeDauw opened this issue Jun 16, 2016 · 3 comments
Closed

Remove usages of deprecated ResultPrinter::getParameters #1654

JeroenDeDauw opened this issue Jun 16, 2016 · 3 comments
Labels
code quality
Milestone
SMW 3.0.0

Comments

@JeroenDeDauw
Copy link
Member

This method is deprecated since 1.8 yet still used by CategoryResultPrinter, EmbeddedResultPrinter and ListResultPrinter. Should not be hard to refactor
@mwjames
Copy link
Contributor

mwjames commented Jun 17, 2016

https://github.com/SemanticMediaWiki/SemanticResultFormats/search?utf8=%E2%9C%93&q=getParameters

@JeroenDeDauw
Copy link
Member Author

To clarrify: this task if about removing the usages of this function in SMW. Not removing the function itself. Of course removing such usages in Semantic Result Formats is also nice.

@kghbln kghbln mentioned this issue Jun 18, 2016
Closed
@kghbln
Copy link
Member

kghbln commented Jun 18, 2016

Here we are: SemanticMediaWiki/SemanticResultFormats#162

@kghbln kghbln added this to the SMW 3.0.0 milestone Jun 22, 2017
@mszabo-wikia mszabo-wikia mentioned this issue Sep 26, 2017
Merged
2 tasks
kghbln added a commit that referenced this issue Sep 27, 2017
@kghbln
Update RELEASE-NOTES.md
9bc1039 
Refs: #2705 (#1654)

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
SMW 3.0.0
Development

No branches or pull requests
3 participants
@JeroenDeDauw @kghbln @mwjames