Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered format, map view: support for customizable icons #239

Closed
krabina opened this Issue Jun 16, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@krabina
Copy link
Contributor

krabina commented Jun 16, 2017

In SRF 2.5.0 the map view in filtered format shows default icons only.

They should
a) be customizable
b) be able to be defined on a per-filter base in order to display e. g. markers with different colors/icons for different sets of data

@krabina

This comment has been minimized.

Copy link
Contributor Author

krabina commented Sep 13, 2018

Should this be closed, because it is done?

I don't understand the usage of

  • map view marker icon property
  • map view marker icons
    though. Can somehone give an example?
@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 13, 2018

Ping @s7eph4n

@s7eph4n

This comment has been minimized.

Copy link
Contributor

s7eph4n commented Sep 14, 2018

Yes, it should be closed.

https://www.semantic-mediawiki.org/wiki/Help:Filtered_format has some documentation:
image

Example:

|map view marker icon property=Has icon
|map view marker icons=building=house.png, bridge=bridge.png, default.png

The icons should be stored as images in the File namespace on the wiki.

@kghbln kghbln closed this Sep 14, 2018

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 14, 2018

I added the parameters to the example.

@s7eph4n

This comment has been minimized.

Copy link
Contributor

s7eph4n commented Sep 14, 2018

Thanks! 👍

@krabina

This comment has been minimized.

Copy link
Contributor Author

krabina commented Sep 14, 2018

Thank you. It is either a icon property OR an icon definition, right? Becaus if I have a property, the defined icon shoudl be used. If I don't have a property, this works if the named files are present
|map view marker icons=building=house.png, bridge=bridge.png, default.png
without any property declaration.

@s7eph4n

This comment has been minimized.

Copy link
Contributor

s7eph4n commented Sep 14, 2018

You will need both. map view marker icon property defines the property that is to be used to select the icon. map view marker icons is the "catalogue" the icon is selected from. So using the example above, if the result element has [[Has icon::building]], the selected marker will be "File:house.png".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.