Gallery format: image dimensions displayed in the captions

[the1gofer]

Setup

• MW version: 1.3
• DB (MySQL etc.): MySQL | 5.6.32-78.1
• PHP version: PHP | 7.0.25 (cgi-fcgi)
• SMW version: 2.5.5
• SRF version: 2.5.4
• Browsers and versions (if applicable): n/a

Issue

Gallery format displays image dimensions in the captions, with no apparent option to remove them.

example: http://crewsgenealogy.com/wiki/index.php?title=United_States_Census,_1870#Images

[mwjames]

Gallery format displays image dimensions in the captions, with no apparent option to remove them.

Issue introduced by WMF in [0]. You have two options, either you ask WMF to restore the default behaviour be setting `protected $mShowDimensions;` to `protected $mShowDimensions = false;` or you extend the gallery class with something like: ``` @@ -65,10 +65,15 @@ class Gallery extends ResultPrinter { // #224 $ig = class_exists( '\TraditionalImageGallery' ) ? new \TraditionalImageGallery() : new \ImageGallery(); $ig->setShowBytes( false ); $ig->setShowFilename( false ); + + if ( method_exists( $ig, 'setShowDimensions' ) ) { + $ig->setShowDimensions( false ); + } ``` In either case, I'd like to see an integration test to avoid a similar situation by the next release before I consider pressing the merge button. [0] wikimedia/mediawiki@ebb1680#diff-c2c646962548f5bc6daffb94201859ef PS: I won't create a PR and only added the necessary context to the issue. Cheers

…

On 2/23/18, the1gofer ***@***.***> wrote: ### Setup - MW version: 1.3 - DB (MySQL etc.): MySQL | 5.6.32-78.1 - PHP version: PHP | 7.0.25 (cgi-fcgi) - SMW version: 2.5.5 - SRF version: 2.5.4 - Browsers and versions (if applicable): n/a ### Issue Gallery format displays image dimensions in the captions, with no apparent option to remove them. example: http://crewsgenealogy.com/wiki/index.php?title=United_States_Census,_1870#Images -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #375

[the1gofer]

is that something that can be done in the config file? or would I need to find it someplace else?

…

On Thu, Feb 22, 2018 at 11:05 AM mwjames ***@***.***> wrote: > Gallery format displays image dimensions in the captions, with no apparent > option to remove them. Issue introduced by WMF in [0]. You have two options, either you ask WMF to restore the default behaviour be setting `protected $mShowDimensions;` to `protected $mShowDimensions = false;` or you extend the gallery class with something like: ``` @@ -65,10 +65,15 @@ class Gallery extends ResultPrinter { // #224 $ig = class_exists( '\TraditionalImageGallery' ) ? new \TraditionalImageGallery() : new \ImageGallery(); $ig->setShowBytes( false ); $ig->setShowFilename( false ); + + if ( method_exists( $ig, 'setShowDimensions' ) ) { + $ig->setShowDimensions( false ); + } ``` In either case, I'd like to see an integration test to avoid a similar situation by the next release before I consider pressing the merge button. [0] wikimedia/mediawiki@ebb1680#diff-c2c646962548f5bc6daffb94201859ef PS: I won't create a PR and only added the necessary context to the issue. Cheers On 2/23/18, the1gofer ***@***.***> wrote: > ### Setup > > - MW version: 1.3 > - DB (MySQL etc.): MySQL | 5.6.32-78.1 > - PHP version: PHP | 7.0.25 (cgi-fcgi) > - SMW version: 2.5.5 > - SRF version: 2.5.4 > - Browsers and versions (if applicable): n/a > > ### Issue > > Gallery format displays image dimensions in the captions, with no apparent > option to remove them. > > example: > http://crewsgenealogy.com/wiki/index.php?title=United_States_Census,_1870#Images > > > > > -- > You are receiving this because you are subscribed to this thread. > Reply to this email directly or view it on GitHub: > #375 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#375 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCqNBhWaAMrU8652je39wKEm7lEKzwnks5tXaxqgaJpZM4SPrlU> .

[mwjames]

is that something that can be done in the config file? or would I need to find it someplace else?

Not sure what you mean with config but as outlined in both cases some code changes are necessary. There is no config because the issue was introduced in the code base that creates the image gallery.

…

On 2/23/18, the1gofer ***@***.***> wrote: is that something that can be done in the config file? or would I need to find it someplace else? On Thu, Feb 22, 2018 at 11:05 AM mwjames ***@***.***> wrote: > > Gallery format displays image dimensions in the captions, with no > apparent > > option to remove them. > > Issue introduced by WMF in [0]. > > You have two options, either you ask WMF to restore the default > behaviour be setting `protected $mShowDimensions;` to `protected > $mShowDimensions = false;` or you extend the gallery class with > something like: > > ``` > @@ -65,10 +65,15 @@ class Gallery extends ResultPrinter { > // #224 > $ig = class_exists( '\TraditionalImageGallery' ) ? new > \TraditionalImageGallery() : new \ImageGallery(); > > $ig->setShowBytes( false ); > $ig->setShowFilename( false ); > + > + if ( method_exists( $ig, 'setShowDimensions' ) ) { > + $ig->setShowDimensions( false ); > + } > ``` > > In either case, I'd like to see an integration test to avoid a similar > situation by the next release before I consider pressing the merge > button. > > [0] > wikimedia/mediawiki@ebb1680#diff-c2c646962548f5bc6daffb94201859ef > > PS: I won't create a PR and only added the necessary context to the > issue. > > Cheers > > On 2/23/18, the1gofer ***@***.***> wrote: > > ### Setup > > > > - MW version: 1.3 > > - DB (MySQL etc.): MySQL | 5.6.32-78.1 > > - PHP version: PHP | 7.0.25 (cgi-fcgi) > > - SMW version: 2.5.5 > > - SRF version: 2.5.4 > > - Browsers and versions (if applicable): n/a > > > > ### Issue > > > > Gallery format displays image dimensions in the captions, with no > apparent > > option to remove them. > > > > example: > > > http://crewsgenealogy.com/wiki/index.php?title=United_States_Census,_1870#Images > > > > > > > > > > -- > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly or view it on GitHub: > > #375 > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#375 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACCqNBhWaAMrU8652je39wKEm7lEKzwnks5tXaxqgaJpZM4SPrlU> > . > -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #375 (comment)

[the1gofer]

Ok, think that’s probably a bit beyond me, but I’ll poke around and see what I can find. Do you know which file it can be found in?

…

On Thu, Feb 22, 2018 at 11:20 AM mwjames ***@***.***> wrote: > is that something that can be done in the config file? or would I need to > find it someplace else? Not sure what you mean with config but as outlined in both cases some code changes are necessary. There is no config because the issue was introduced in the code base that creates the image gallery. On 2/23/18, the1gofer ***@***.***> wrote: > is that something that can be done in the config file? or would I need to > find it someplace else? > > On Thu, Feb 22, 2018 at 11:05 AM mwjames ***@***.***> wrote: > >> > Gallery format displays image dimensions in the captions, with no >> apparent >> > option to remove them. >> >> Issue introduced by WMF in [0]. >> >> You have two options, either you ask WMF to restore the default >> behaviour be setting `protected $mShowDimensions;` to `protected >> $mShowDimensions = false;` or you extend the gallery class with >> something like: >> >> ``` >> @@ -65,10 +65,15 @@ class Gallery extends ResultPrinter { >> // #224 >> $ig = class_exists( '\TraditionalImageGallery' ) ? new >> \TraditionalImageGallery() : new \ImageGallery(); >> >> $ig->setShowBytes( false ); >> $ig->setShowFilename( false ); >> + >> + if ( method_exists( $ig, 'setShowDimensions' ) ) { >> + $ig->setShowDimensions( false ); >> + } >> ``` >> >> In either case, I'd like to see an integration test to avoid a similar >> situation by the next release before I consider pressing the merge >> button. >> >> [0] >> wikimedia/mediawiki@ebb1680#diff-c2c646962548f5bc6daffb94201859ef >> >> PS: I won't create a PR and only added the necessary context to the >> issue. >> >> Cheers >> >> On 2/23/18, the1gofer ***@***.***> wrote: >> > ### Setup >> > >> > - MW version: 1.3 >> > - DB (MySQL etc.): MySQL | 5.6.32-78.1 >> > - PHP version: PHP | 7.0.25 (cgi-fcgi) >> > - SMW version: 2.5.5 >> > - SRF version: 2.5.4 >> > - Browsers and versions (if applicable): n/a >> > >> > ### Issue >> > >> > Gallery format displays image dimensions in the captions, with no >> apparent >> > option to remove them. >> > >> > example: >> > >> http://crewsgenealogy.com/wiki/index.php?title=United_States_Census,_1870#Images >> > >> > >> > >> > >> > -- >> > You are receiving this because you are subscribed to this thread. >> > Reply to this email directly or view it on GitHub: >> > #375 >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> < #375 (comment) >, >> or mute the thread >> < https://github.com/notifications/unsubscribe-auth/ACCqNBhWaAMrU8652je39wKEm7lEKzwnks5tXaxqgaJpZM4SPrlU > >> . >> > > > -- > You are receiving this because you commented. > Reply to this email directly or view it on GitHub: > #375 (comment) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#375 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCqNCjaTgalEwG7QVzfXYJRskewFzrmks5tXa_-gaJpZM4SPrlU> .

[the1gofer]

Never mind, please excuse my ignorance. Thanks for the help.

…

On Thu, Feb 22, 2018 at 11:36 AM Jason Crews ***@***.***> wrote: Ok, think that’s probably a bit beyond me, but I’ll poke around and see what I can find. Do you know which file it can be found in? On Thu, Feb 22, 2018 at 11:20 AM mwjames ***@***.***> wrote: > > is that something that can be done in the config file? or would I need > to > > find it someplace else? > > Not sure what you mean with config but as outlined in both cases some > code changes are necessary. There is no config because the issue was > introduced in the code base that creates the image gallery. > > On 2/23/18, the1gofer ***@***.***> wrote: > > is that something that can be done in the config file? or would I need > to > > find it someplace else? > > > > On Thu, Feb 22, 2018 at 11:05 AM mwjames ***@***.***> > wrote: > > > >> > Gallery format displays image dimensions in the captions, with no > >> apparent > >> > option to remove them. > >> > >> Issue introduced by WMF in [0]. > >> > >> You have two options, either you ask WMF to restore the default > >> behaviour be setting `protected $mShowDimensions;` to `protected > >> $mShowDimensions = false;` or you extend the gallery class with > >> something like: > >> > >> ``` > >> @@ -65,10 +65,15 @@ class Gallery extends ResultPrinter { > >> // #224 > >> $ig = class_exists( '\TraditionalImageGallery' ) ? new > >> \TraditionalImageGallery() : new \ImageGallery(); > >> > >> $ig->setShowBytes( false ); > >> $ig->setShowFilename( false ); > >> + > >> + if ( method_exists( $ig, 'setShowDimensions' ) ) { > >> + $ig->setShowDimensions( false ); > >> + } > >> ``` > >> > >> In either case, I'd like to see an integration test to avoid a similar > >> situation by the next release before I consider pressing the merge > >> button. > >> > >> [0] > >> > wikimedia/mediawiki@ebb1680#diff-c2c646962548f5bc6daffb94201859ef > >> > >> PS: I won't create a PR and only added the necessary context to the > >> issue. > >> > >> Cheers > >> > >> On 2/23/18, the1gofer ***@***.***> wrote: > >> > ### Setup > >> > > >> > - MW version: 1.3 > >> > - DB (MySQL etc.): MySQL | 5.6.32-78.1 > >> > - PHP version: PHP | 7.0.25 (cgi-fcgi) > >> > - SMW version: 2.5.5 > >> > - SRF version: 2.5.4 > >> > - Browsers and versions (if applicable): n/a > >> > > >> > ### Issue > >> > > >> > Gallery format displays image dimensions in the captions, with no > >> apparent > >> > option to remove them. > >> > > >> > example: > >> > > >> > http://crewsgenealogy.com/wiki/index.php?title=United_States_Census,_1870#Images > >> > > >> > > >> > > >> > > >> > -- > >> > You are receiving this because you are subscribed to this thread. > >> > Reply to this email directly or view it on GitHub: > >> > > #375 > >> > >> — > >> You are receiving this because you authored the thread. > >> Reply to this email directly, view it on GitHub > >> < > #375 (comment) > >, > >> or mute the thread > >> < > https://github.com/notifications/unsubscribe-auth/ACCqNBhWaAMrU8652je39wKEm7lEKzwnks5tXaxqgaJpZM4SPrlU > > > >> . > >> > > > > > > -- > > You are receiving this because you commented. > > Reply to this email directly or view it on GitHub: > > > #375 (comment) > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#375 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACCqNCjaTgalEwG7QVzfXYJRskewFzrmks5tXa_-gaJpZM4SPrlU> > . >

[kghbln]

Thanks for reporting.

either you ask WMF to restore the default behaviour be setting protected $mShowDimensions; to protected $mShowDimensions = false;

From experience we should not hold our breath here, so updating the gallery format is probably the better solution.

[anrake]

Hi is there any progress to update SRF for this issue?

[mwjames]

Hi is there any progress to update SRF for this issue?

I think I gave all the required information for community members to act on. If nothing has happened yet then project members didn't find the time to make the necessary changes, yet we are happily accept PRs.

[anrake]

Thanks, I think I'm a little inexperienced to help out so will wait for some kind person to hopefully fix this.