Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alias and magic file into i18n folder #5

Closed
mwjames opened this issue Jan 26, 2015 · 5 comments
Closed

Move alias and magic file into i18n folder #5

mwjames opened this issue Jan 26, 2015 · 5 comments

Comments

@mwjames
Copy link
Contributor

mwjames commented Jan 26, 2015

Follow-up to #3 (comment)

  • SemanticSignup.i18n.aliases.php
  • SemanticSignup.i18n.magic.php
@mwjames
Copy link
Contributor Author

mwjames commented Jan 26, 2015

@kghbln FYI

@kghbln
Copy link
Member

kghbln commented Jan 26, 2015

Ah yes. Shame on me. I forgot. :(

@siebrand Will it be possible to move files with the translations for the e.g. aliases and namespaces (not this extension though) into the i18n folder without breaking the process with translatewiki.net?

@mwjames mwjames changed the title Move alias and magic into i18n folder Move alias and magic file into i18n folder Jan 26, 2015
@siebrand
Copy link
Member

Yes, that's possible. Please ping @raymondde when you do that, as we need to update some configuration in mediawiki-extensions.txt for translatewiki.net. I'm not a fan, though, because I think that we should integrate the contents of the mentioned files in the JSON files, and not add PHP files in that folder. There are no technical reasons to not do it, though.

@kghbln
Copy link
Member

kghbln commented Jan 26, 2015

Thank you for your info and insight!

@mwjames
Copy link
Contributor Author

mwjames commented Jan 26, 2015

though, because I think that we should integrate the contents of the mentioned files in the JSON files, and not add PHP files in that folder. There are no technical reasons to not do it, though.

If at some point alias/magic arrays get integrated into JSON then this is fine but i18n belongs in its respective folder and not into the root directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants