Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support online_eval to improve training performance #89

Merged
merged 9 commits into from Jan 19, 2021
Merged

Conversation

senwu
Copy link
Owner

@senwu senwu commented Jan 14, 2021

Description of the problems or issues

Support online_eval to improve training performance

Description of the proposed changes

Add online_eval argument

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the CHANGELOG.rst accordingly.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #89 (c5b748b) into master (1a35ab3) will decrease coverage by 0.28%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   87.73%   87.45%   -0.29%     
==========================================
  Files          38       38              
  Lines        1745     1753       +8     
  Branches      375      379       +4     
==========================================
+ Hits         1531     1533       +2     
- Misses        114      116       +2     
- Partials      100      104       +4     
Flag Coverage Δ
unittests 87.45% <73.68%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/emmental/meta.py 80.00% <ø> (ø)
src/emmental/model.py 80.06% <72.72%> (-1.32%) ⬇️
src/emmental/learner.py 76.06% <75.00%> (-0.30%) ⬇️
src/emmental/utils/parse_args.py 99.27% <100.00%> (+<0.01%) ⬆️

@senwu senwu merged commit cde0634 into master Jan 19, 2021
@senwu senwu deleted the online_eval branch January 19, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant