Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Changes #3

Merged
merged 3 commits into from Apr 18, 2022
Merged

Some Changes #3

merged 3 commits into from Apr 18, 2022

Conversation

proguy914629bot
Copy link
Contributor

@proguy914629bot proguy914629bot commented Apr 18, 2022

This leaves with a huge PR with 600+ additions and 100+ deletions.

Here are the following list of added/deleted/modified things that apply to this PR:

  • Enforce/Follow PEP 8 (according to PyCharm) and PEP 252 with staticmethod-s and classmethod-s.
  • Changed .gitignore file to Python Gitignore.
  • Added GlobalJSON in favor of the old JSON which now supports Global and Local JSON.
  • Added MISSING in favor of doing MISSING = 0.0 instead (from discord.py).
  • Use typing overload to improve type checking and linters.
  • Added GlobalCache in favor of the old Cache which now supports Global and Local Cache.
  • Change startwith to startswith and endwith to endswith (spelling) in Compile class for the following methods:
    • Compile.string
    • Compile.to_string
    • Compile.numbers
  • Change windows commands in os.py file:
    • From python3 to py
    • From pip to py -m pip
  • Change OPTION to OPTIONS (speling).
  • Add staticmethod-s to Terminal class.
  • Use is instead of == and is not instead of != when comparing to None.
  • Change version 1.2.1.4 to 1.2.2.

And some more that I probably forgot to note here.

Copy link
Collaborator

@BenitzCoding BenitzCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change to MISSING variable, and makes the code quality better and improves stability. This enforces PEP, which is great!

@BenitzCoding BenitzCoding merged commit 7192f72 into Senarc-Studios:main Apr 18, 2022
@proguy914629bot proguy914629bot deleted the changes branch April 18, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants