Remove all uses of React.FC in our TypeScript code #1553
Labels
area: front-end
area: nextjs
Nextjs related issues
developer experience
Helping the Developer Experience
type: bug
Something isn't working
Milestone
What happened:
We have a mix of different approaches to defining our React components in the next.js TypeScript. In some places we use
React.FC
for typing, and in others we don't.Let's remove all instances of
React.FC
.What should have happened:
According to facebook/create-react-app#8177, there are some issues with always using
FC
, and we'd probably be better served by removing it. I also think this will be a win for new React devs who don't know TS very well, and encounterFC
for the first time in our code.If you're reviewing new code, ask the developer to remove
FC
. For any that slips in, let's do a sweep and remove it all later on.See also discussion in #1531 (comment).
The text was updated successfully, but these errors were encountered: