Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Wildcard ('*') Header Use in Telescope #2121

Closed
Metropass opened this issue Apr 10, 2021 · 4 comments
Closed

Audit Wildcard ('*') Header Use in Telescope #2121

Metropass opened this issue Apr 10, 2021 · 4 comments
Labels

Comments

@Metropass
Copy link
Contributor

What would you like to be added:

Figure out where we use the Wildcard * Header for CORS in Telescope
Why would you like this to be added:

While working on #667, I noticed that the Wildcard operator is not implemented in Safari on iOS and Firefox for Android.

Since we have a mobile UI for Telescope, we should probably audit where we use the Wildcard operator, and pass in the headers that we want to use. (if the person is using the browsers above)
Screenshot_415

@Metropass Metropass added type: enhancement New feature or request area: back-end good first issue Good for newcomers labels Apr 10, 2021
@birtony
Copy link
Contributor

birtony commented Apr 13, 2021

We specifically use two headers (link, x-count) and the old back-end sets these for CORS. We should probably set these for Satellite.

@aserputov
Copy link
Contributor

Related #2444

@DiegoHdz7
Copy link

Hi, I would like to take this issue for the hacktoberfest, can I take it?

@humphd humphd removed the good first issue Good for newcomers label Sep 28, 2022
@humphd
Copy link
Contributor

humphd commented Jan 20, 2023

I don't think this is an issue. Re-open if we find otherwise.

@humphd humphd closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants