Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some texts are invisible in search page (dark mode) #2168

Closed
yuanLeeMidori opened this issue Apr 16, 2021 · 2 comments · Fixed by #2184
Closed

Some texts are invisible in search page (dark mode) #2168

yuanLeeMidori opened this issue Apr 16, 2021 · 2 comments · Fixed by #2184
Assignees
@yuanLeeMidori
Labels
area: accessibility Making Telescope accessible for all kinds of users area: front-end type: bug Something isn't working
Projects
UI 2.0
Milestone
2.0 Release

Comments

@yuanLeeMidori
Copy link
Contributor

What happened:
Some texts in search page are invisible in dark mode.

"No more posts found" is invisible in dark mode
chrome-capture (2)

"No result found" is invisible in dark mode
chrome-capture (3)
@yuanLeeMidori yuanLeeMidori added type: bug Something isn't working area: front-end area: accessibility Making Telescope accessible for all kinds of users labels Apr 16, 2021
@yuanLeeMidori yuanLeeMidori added this to the 2.0 Release milestone Apr 16, 2021
@yuanLeeMidori yuanLeeMidori self-assigned this Apr 16, 2021
@PedroFonsecaDEV PedroFonsecaDEV added this to To do in UI 2.0 Apr 17, 2021
@HyperTHD
Copy link
Contributor

Think we might need a new image specifically for dark mode. Shouldn't be too hard to find

@yuanLeeMidori
Copy link
Contributor Author

Think we might need a new image specifically for dark mode. Shouldn't be too hard to find

That is true. Let me open another issue, thanks!

@yuanLeeMidori yuanLeeMidori mentioned this issue Apr 20, 2021
Merged
8 tasks
@yuanLeeMidori yuanLeeMidori moved this from To do to Done in UI 2.0 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuanLeeMidori yuanLeeMidori

Labels
area: accessibility Making Telescope accessible for all kinds of users area: front-end type: bug Something isn't working
Projects
No open projects
UI 2.0
  
Done
Milestone
2.0 Release
Development

Successfully merging a pull request may close this issue.

Improve contrast ratio in contributor card and search results message yuanLeeMidori/telescope
2 participants
@HyperTHD @yuanLeeMidori