Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile UX/UI for GitHub post info #2373

Closed
humphd opened this issue Oct 20, 2021 · 3 comments · Fixed by #2716
Closed

Mobile UX/UI for GitHub post info #2373

humphd opened this issue Oct 20, 2021 · 3 comments · Fixed by #2716
Assignees
Labels
area: accessibility Making Telescope accessible for all kinds of users area: css styling Anything related to CSS styling area: design Issues needing design or assets area: front-end type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Oct 20, 2021

In #2367 we are adding GitHub info to the sidebar for a post. Currently, it only works in desktop, and there's nothing visible in mobile. I'd like to see if we can add a design and UI for the mobile case.

One option might be to show a collapsed GitHub area that expands when you touch it. If there's no GitHub details, we wouldn't show it. But if a post does have any, we'd include a GitHub icon or something that you can use to drill down and see more.

Obviously we don't want to show this all the time, but it would be good if you could access it on demand.

@humphd humphd added type: enhancement New feature or request area: front-end area: design Issues needing design or assets area: css styling Anything related to CSS styling area: accessibility Making Telescope accessible for all kinds of users labels Oct 20, 2021
@irenejoeunpark
Copy link
Contributor

Hi @humphd, If no one has started working on this, can I start contributing to the UI implementation for mobiles?

@humphd
Copy link
Contributor Author

humphd commented Nov 3, 2021

@irenejoeunpark that would be great, please do. I would encourage you to chat with people in the #telescope channel on Slack, as many of the devs/users will have opinions about this, so getting community input early will be key. Also, we can do this in stages (e.g., you don't have to solve the whole thing in one PR).

Looking forward to seeing this happen!

@sirinoks
Copy link
Contributor

We have just completed changing a column view of isses/PRs to a row and fixed its wrapping. Await for the PR for that one. @TueeNguyen should make the PR.

There is another task to impove the view, which turned out to be more difficult than we first thought. I will create another issue describing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility Making Telescope accessible for all kinds of users area: css styling Anything related to CSS styling area: design Issues needing design or assets area: front-end type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants